You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/08 13:32:35 UTC

[GitHub] [pulsar] MarvinCai commented on a diff in pull request #17408: [fix][test] Fix flaky test TopicReaderTest.testMultiReaderIsAbleToSeekWithTimeOnMiddleOfTopic

MarvinCai commented on code in PR #17408:
URL: https://github.com/apache/pulsar/pull/17408#discussion_r965975924


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/TopicReaderTest.java:
##########
@@ -70,6 +70,7 @@ public class TopicReaderTest extends ProducerConsumerBase {
     @BeforeClass
     @Override
     protected void setup() throws Exception {
+        this.conf.setBrokerDeduplicationEnabled(true);

Review Comment:
   `producer.send(String.format("msg num %d", i).getBytes());`
   the test is not sending duplicate message, why we need to dedup though?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org