You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Ingmar Kliche (JIRA)" <ji...@apache.org> on 2008/07/30 19:35:31 UTC

[jira] Created: (SCXML-80) SCXMLParser: Should the parser throw an exception on a parsing error?

SCXMLParser: Should the parser throw an exception on a parsing error?
---------------------------------------------------------------------

                 Key: SCXML-80
                 URL: https://issues.apache.org/jira/browse/SCXML-80
             Project: Commons SCXML
          Issue Type: Improvement
    Affects Versions: 0.8
            Reporter: Ingmar Kliche


I noticed that the SCXMLParser::DigestSrcAttributeRule() function only logs a message (and returns to continue parsing at next element) in case there is trouble in resolving the src-Attribute (i.e. to source in content from other SCXML documents). The particular use case is a wrong fraction of the src-Attribute of the <state> tag, i.e. if the state which was refered to using the url fraction does not exist in the target document.

Thus when using the parser it is not possible to know whether the parsing was actually successful. In the above given use case the parser returns a valid - but incomplete - statemachine. And this is a severe problem. 

Hence, shouldn't the parsing error bubble up, e.g. using an exception?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SCXML-80) SCXMLParser: Should the parser throw an exception on a parsing error?

Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SCXML-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rahul Akolkar resolved SCXML-80.
--------------------------------

    Resolution: Fixed

This will now result in a SAXException (which the parse() methods already throw), and has been fixed in trunk.


> SCXMLParser: Should the parser throw an exception on a parsing error?
> ---------------------------------------------------------------------
>
>                 Key: SCXML-80
>                 URL: https://issues.apache.org/jira/browse/SCXML-80
>             Project: Commons SCXML
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Ingmar Kliche
>             Fix For: 0.9
>
>
> I noticed that the SCXMLParser::DigestSrcAttributeRule() function only logs a message (and returns to continue parsing at next element) in case there is trouble in resolving the src-Attribute (i.e. to source in content from other SCXML documents). The particular use case is a wrong fraction of the src-Attribute of the <state> tag, i.e. if the state which was refered to using the url fraction does not exist in the target document.
> Thus when using the parser it is not possible to know whether the parsing was actually successful. In the above given use case the parser returns a valid - but incomplete - statemachine. And this is a severe problem. 
> Hence, shouldn't the parsing error bubble up, e.g. using an exception?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SCXML-80) SCXMLParser: Should the parser throw an exception on a parsing error?

Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SCXML-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rahul Akolkar updated SCXML-80:
-------------------------------

    Fix Version/s: 0.9

Yes, the parser should cease processing with a fatal exception (probably a Commons SCXML ModelException). If I remember my digester correctly, it will actually be manifested as a SAXException as it bubbles up.

Thanks for the report. Setting fix version to v0.9, the next release.


> SCXMLParser: Should the parser throw an exception on a parsing error?
> ---------------------------------------------------------------------
>
>                 Key: SCXML-80
>                 URL: https://issues.apache.org/jira/browse/SCXML-80
>             Project: Commons SCXML
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Ingmar Kliche
>             Fix For: 0.9
>
>
> I noticed that the SCXMLParser::DigestSrcAttributeRule() function only logs a message (and returns to continue parsing at next element) in case there is trouble in resolving the src-Attribute (i.e. to source in content from other SCXML documents). The particular use case is a wrong fraction of the src-Attribute of the <state> tag, i.e. if the state which was refered to using the url fraction does not exist in the target document.
> Thus when using the parser it is not possible to know whether the parsing was actually successful. In the above given use case the parser returns a valid - but incomplete - statemachine. And this is a severe problem. 
> Hence, shouldn't the parsing error bubble up, e.g. using an exception?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.