You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jihoon Son <ji...@apache.org> on 2014/03/06 13:43:38 UTC
Review Request 18843: TAJO-612: Missing INET4 type in SQLParder
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/
-----------------------------------------------------------
Review request for Tajo.
Repository: tajo
Description
-------
See the title. SQLParser cannot parse the INET4 type.
I fixed the problem of parser and some missing codes for processing of INET4 type.
I also added two functions of country() and in_country() for INET4 type.
Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
Diffs
-----
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
Diff: https://reviews.apache.org/r/18843/diff/
Testing
-------
mvn verify
Thanks,
Jihoon Son
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParder
Posted by Jihoon Son <ji...@apache.org>.
> On March 8, 2014, 12:55 a.m., Hyunsik Choi wrote:
> > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java, line 39
> > <https://reviews.apache.org/r/18843/diff/3/?file=512351#file512351line39>
> >
> > I have one more suggestion. If you are Ok, could you add some documentation for these functions at http://tajo.incubator.apache.org/docs/0.8.0/functions.html?
> >
> > I think that 'Network Functions and Operations' would be a good candidate name of your proposed functions. Otherwise, feel free to suggest your prefer name.
> >
> > The following instruction would be helpful for you. If you need any help, feel free to ask me.
> > http://wiki.apache.org/tajo/HowToWriteUserDocumentations
Sure, I'm willing to. :)
- Jihoon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/#review36526
-----------------------------------------------------------
On March 7, 2014, 12:09 a.m., Jihoon Son wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18843/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 12:09 a.m.)
>
>
> Review request for Tajo.
>
>
> Repository: tajo
>
>
> Description
> -------
>
> See the title. SQLParser cannot parse the INET4 type.
> I fixed the problem of parser and some missing codes for processing of INET4 type.
> I also added two functions of country() and in_country() for INET4 type.
> Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
>
>
> Diffs
> -----
>
> tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18843/diff/
>
>
> Testing
> -------
>
> mvn verify
>
>
> Thanks,
>
> Jihoon Son
>
>
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParder
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/#review36526
-----------------------------------------------------------
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java
<https://reviews.apache.org/r/18843/#comment67520>
I have one more suggestion. If you are Ok, could you add some documentation for these functions at http://tajo.incubator.apache.org/docs/0.8.0/functions.html?
I think that 'Network Functions and Operations' would be a good candidate name of your proposed functions. Otherwise, feel free to suggest your prefer name.
The following instruction would be helpful for you. If you need any help, feel free to ask me.
http://wiki.apache.org/tajo/HowToWriteUserDocumentations
- Hyunsik Choi
On March 7, 2014, 12:09 a.m., Jihoon Son wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18843/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 12:09 a.m.)
>
>
> Review request for Tajo.
>
>
> Repository: tajo
>
>
> Description
> -------
>
> See the title. SQLParser cannot parse the INET4 type.
> I fixed the problem of parser and some missing codes for processing of INET4 type.
> I also added two functions of country() and in_country() for INET4 type.
> Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
>
>
> Diffs
> -----
>
> tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18843/diff/
>
>
> Testing
> -------
>
> mvn verify
>
>
> Thanks,
>
> Jihoon Son
>
>
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParder
Posted by Jihoon Son <ji...@apache.org>.
> On March 7, 2014, 9:55 p.m., Hyunsik Choi wrote:
> > It's nice work. This patch adds a really nice feature to Tajo. Besides the inline comments, I have one suggestion. It would be great to rename the config 'tajo.geoip.data' into 'tajo.functions.geoip.data-location'? I think that the second name part 'geoip' is too higher than its importance in Tajo system.
Thanks for your review.
I'll upload a new patch after reflecting your comments.
- Jihoon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/#review36513
-----------------------------------------------------------
On March 7, 2014, 12:09 a.m., Jihoon Son wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18843/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 12:09 a.m.)
>
>
> Review request for Tajo.
>
>
> Repository: tajo
>
>
> Description
> -------
>
> See the title. SQLParser cannot parse the INET4 type.
> I fixed the problem of parser and some missing codes for processing of INET4 type.
> I also added two functions of country() and in_country() for INET4 type.
> Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
>
>
> Diffs
> -----
>
> tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18843/diff/
>
>
> Testing
> -------
>
> mvn verify
>
>
> Thanks,
>
> Jihoon Son
>
>
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParder
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/#review36513
-----------------------------------------------------------
It's nice work. This patch adds a really nice feature to Tajo. Besides the inline comments, I have one suggestion. It would be great to rename the config 'tajo.geoip.data' into 'tajo.functions.geoip.data-location'? I think that the second name part 'geoip' is too higher than its importance in Tajo system.
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java
<https://reviews.apache.org/r/18843/#comment67505>
Recently, functions were moved into some specific directories, such as math, datetime, and string. It would be great if you move these functions into some proper package like geoip.
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java
<https://reviews.apache.org/r/18843/#comment67506>
I like the function you proposed. But, this function name 'country' is too general for me. It would be nice if these functions have some prefix like 'geoip_'.
In addition, 'country' function results in country code. So, I would like to suggest the name 'geoip_country_code'. It looks very intuitive for me.
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryInet4.java
<https://reviews.apache.org/r/18843/#comment67507>
I would like to suggest the name 'geoip_in_country' due to the same reason of geoip_country_code.
- Hyunsik Choi
On March 7, 2014, 12:09 a.m., Jihoon Son wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18843/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 12:09 a.m.)
>
>
> Review request for Tajo.
>
>
> Repository: tajo
>
>
> Description
> -------
>
> See the title. SQLParser cannot parse the INET4 type.
> I fixed the problem of parser and some missing codes for processing of INET4 type.
> I also added two functions of country() and in_country() for INET4 type.
> Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
>
>
> Diffs
> -----
>
> tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18843/diff/
>
>
> Testing
> -------
>
> mvn verify
>
>
> Thanks,
>
> Jihoon Son
>
>
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParser
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/#review36750
-----------------------------------------------------------
+1
It's really nice work. Ship it!
- Hyunsik Choi
On March 10, 2014, 10:27 p.m., Jihoon Son wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18843/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 10:27 p.m.)
>
>
> Review request for Tajo.
>
>
> Repository: tajo
>
>
> Description
> -------
>
> See the title. SQLParser cannot parse the INET4 type.
> I fixed the problem of parser and some missing codes for processing of INET4 type.
> I also added two functions of country() and in_country() for INET4 type.
> Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
>
>
> Diffs
> -----
>
> tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPInCountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPInCountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/GeoIPUtil.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/GeoUtil.java 6028725
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
> tajo-docs/src/main/sphinx/functions.rst e021f00
> tajo-docs/src/main/sphinx/functions/network_func_and_operators.rst PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18843/diff/
>
>
> Testing
> -------
>
> mvn verify
>
>
> Thanks,
>
> Jihoon Son
>
>
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParser
Posted by Jihoon Son <ji...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/
-----------------------------------------------------------
(Updated March 10, 2014, 10:27 p.m.)
Review request for Tajo.
Changes
-------
I reflected Hyunsik's comments.
Repository: tajo
Description
-------
See the title. SQLParser cannot parse the INET4 type.
I fixed the problem of parser and some missing codes for processing of INET4 type.
I also added two functions of country() and in_country() for INET4 type.
Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
Diffs (updated)
-----
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPInCountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPInCountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/GeoIPUtil.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/GeoUtil.java 6028725
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
tajo-docs/src/main/sphinx/functions.rst e021f00
tajo-docs/src/main/sphinx/functions/network_func_and_operators.rst PRE-CREATION
Diff: https://reviews.apache.org/r/18843/diff/
Testing
-------
mvn verify
Thanks,
Jihoon Son
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParser
Posted by Jihoon Son <ji...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/
-----------------------------------------------------------
(Updated March 8, 2014, 2:52 p.m.)
Review request for Tajo.
Summary (updated)
-----------------
TAJO-612: Missing INET4 type in SQLParser
Repository: tajo
Description
-------
See the title. SQLParser cannot parse the INET4 type.
I fixed the problem of parser and some missing codes for processing of INET4 type.
I also added two functions of country() and in_country() for INET4 type.
Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
Diffs
-----
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
Diff: https://reviews.apache.org/r/18843/diff/
Testing
-------
mvn verify
Thanks,
Jihoon Son
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParder
Posted by Jihoon Son <ji...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/
-----------------------------------------------------------
(Updated March 7, 2014, 12:09 a.m.)
Review request for Tajo.
Changes
-------
Fix to handle the null input in country and in_country functions.
Repository: tajo
Description
-------
See the title. SQLParser cannot parse the INET4 type.
I fixed the problem of parser and some missing codes for processing of INET4 type.
I also added two functions of country() and in_country() for INET4 type.
Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
Diffs (updated)
-----
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
Diff: https://reviews.apache.org/r/18843/diff/
Testing
-------
mvn verify
Thanks,
Jihoon Son