You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/03/20 15:12:55 UTC

[GitHub] incubator-brooklyn pull request: Fix for HA hot backup warnings, b...

GitHub user ahgittin opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/561

    Fix for HA hot backup warnings, better HA logging, and standby shutdown

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/incubator-brooklyn fix-ha-hot-backup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #561
    
----
commit cda8069e01e9eeb0d0cd1792ae0d67713a0c465d
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2015-03-20T12:31:58Z

    fixes for HA hot backup and notes on better management for subsequent rebinds
    
    for child nodes, we apply management to the latest pre-registered instance, not a cached proxy;
    and lots of notes on manageAll(...) as a better approach than the current manageRebindedRoot

commit e400d777b0b3dea91c285ff4680fc757b1e9d49a
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2015-03-19T16:23:00Z

    allow REST server shutdown POST when running as standby or backup
    
    modifies HaMasterCheckFilter, simplifying the code, and adding an extra check to allow a "shutdown (leave apps running)" POST
    (otherwise all other POSTs and PATCHes are disallowed, unless a special header is added, but GET and HEAD *are* allowed)

commit d04d560aed764c7637c8cba24ff2fd2300558bd8
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2015-03-20T14:06:45Z

    cleaned up how non-master filter errors are reported

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix for HA hot backup warnings, b...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/561#issuecomment-84057462
  
    Failing test(s) look real, e.g.:
    
        brooklyn.rest.domain.ApiErrorTest.testSerializeApiError
    
        java.lang.AssertionError: expected [{"message":"explanatory message","details":"accompanying details"}] but found [{"message":"explanatory message","details":"accompanying details","errorCode":null}]



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix for HA hot backup warnings, b...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/561#issuecomment-84059130
  
    Changes look good, though I confess the if-else conditional behaviour for master/standby is getting fiddly to follow - particularly if just looking at the diff, rather than all the code!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix for HA hot backup warnings, b...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/561


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---