[GitHub] [mesos] cf-natali commented on a change in pull request #383: Add mesos authentication to the mesos cli

[GitBox <gi...@apache.org>]

cf-natali commented on a change in pull request #383:
URL: https://github.com/apache/mesos/pull/383#discussion_r644249049



##########
File path: src/python/cli_new/lib/cli/config.py
##########
@@ -119,6 +120,79 @@ def master(self):
 
         return master
 
+    def principal(self):
+        """
+        Return the principal in the configuration file
+        """
+        return self.data["master"].get("principal")
+
+    def secret(self):
+        """
+        Return the secret in the configuration file
+        """
+        return self.data["master"].get("secret")
+
+    def agent_ssl(self, default=False):
+        """
+        Return if the agent support ssl
+        """
+        if "agent" in self.data:
+            agent_ssl = self.data["agent"].get("ssl", default)
+            if not isinstance(agent_ssl, bool):
+                raise CLIException("The 'agent->ssl' field"
+                                   " must be True/False")
+
+            return agent_ssl
+
+        return default

Review comment:
       So you can simplify it even further by using a default for `self.data["agent"], like this]:
   ```
   def agent_ssl(self, default=False):
       agent_ssl = self.data.get("agent", {}).get("ssl", default)
       if not isinstance(agent_ssl, bool):
           raise CLIException("The 'agent->ssl' field must be True/False"
       return agent_ssl
   ```
   
   Personally I like it because it removes a repetition between checking that `"agent"` is in `data` and then accessing it, and also it removes a branch, but up to you if you find it less natural.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org