You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/11 20:25:23 UTC
[kudu-CR](branch-1.11.x) [clock] log on CombineClocks() status only via VLOG
Hello Kudu Jenkins, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14417
to review the following change.
Change subject: [clock] log on CombineClocks() status only via VLOG
......................................................................
[clock] log on CombineClocks() status only via VLOG
The logs about the walltime-would-move-back outcome of
BuiltInNtp::CombineClocks() look a bit scary, but de facto they
are benign and of nothing irregular in case of jittery reference
servers. Let's output them as VLOG(1) messages. These should
eventually be gone once the proper clock selection algorithm is
implemented (see KUDU-2939 for details).
Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd
Reviewed-on: http://gerrit.cloudera.org:8080/14416
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 2768c156186e3da9693ddeff78a8d3206827fb88)
---
M src/kudu/clock/builtin_ntp.cc
1 file changed, 8 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14417/1
--
To view, visit http://gerrit.cloudera.org:8080/14417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd
Gerrit-Change-Number: 14417
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [clock] log on CombineClocks() status only via VLOG
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14417 )
Change subject: [clock] log on CombineClocks() status only via VLOG
......................................................................
[clock] log on CombineClocks() status only via VLOG
The logs about the walltime-would-move-back outcome of
BuiltInNtp::CombineClocks() look a bit scary, but de facto they
are benign and of nothing irregular in case of jittery reference
servers. Let's output them as VLOG(1) messages. These should
eventually be gone once the proper clock selection algorithm is
implemented (see KUDU-2939 for details).
Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd
Reviewed-on: http://gerrit.cloudera.org:8080/14416
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 2768c156186e3da9693ddeff78a8d3206827fb88)
Reviewed-on: http://gerrit.cloudera.org:8080/14417
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/clock/builtin_ntp.cc
1 file changed, 8 insertions(+), 12 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd
Gerrit-Change-Number: 14417
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [clock] log on CombineClocks() status only via VLOG
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14417 )
Change subject: [clock] log on CombineClocks() status only via VLOG
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd
Gerrit-Change-Number: 14417
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Oct 2019 23:47:59 +0000
Gerrit-HasComments: No