[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #2343: chore(bindings/java): improve OpenDALException tests and docs

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #2343:
URL: https://github.com/apache/incubator-opendal/pull/2343#discussion_r1207990257


##########
bindings/java/src/main/java/org/apache/opendal/exception/OpenDALException.java:
##########
@@ -19,23 +19,46 @@
 
 package org.apache.opendal.exception;
 
-public class ODException extends RuntimeException {
+/**
+ * A OpenDALException encapsulates the error of an operation. This exception
+ * type is used to describe an internal error from the native opendal library.
+ */
+public class OpenDALException extends RuntimeException {

Review Comment:
   After a second consideration, I believe `OpenDALException` is good for Java idiom. This is also how RocksDB names its `RocksDBException` - we don't need save letters here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org