[GitHub] [kafka] guozhangwang commented on a change in pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

[GitBox <gi...@apache.org>]

guozhangwang commented on a change in pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#discussion_r696987413



##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -495,9 +498,25 @@ private void replaceStreamThread(final Throwable throwable) {
         }
     }
 
+    private StreamsUncaughtExceptionHandler.StreamThreadExceptionResponse getActionForThrowable(final Throwable throwable,
+                                                                                        final StreamsUncaughtExceptionHandler streamsUncaughtExceptionHandler) {
+        final StreamsUncaughtExceptionHandler.StreamThreadExceptionResponse action;
+        // Exception might we wrapped within a StreamsException one

Review comment:
       Hmm I think it should be "always" wrapped, if not then that would be a bug.. before line 500 we can check if `cause()` exists and if that's illegal-state etc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org