You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/08/28 10:34:38 UTC

[GitHub] [phoenix-connectors] richardantal opened a new pull request #29: PHOENIX-6103 Replace apache.commons.logging in Phoenix-Connectors

richardantal opened a new pull request #29:
URL: https://github.com/apache/phoenix-connectors/pull/29


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-connectors] stoty commented on a change in pull request #29: PHOENIX-6103 Replace apache.commons.logging in Phoenix-Connectors

Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #29:
URL: https://github.com/apache/phoenix-connectors/pull/29#discussion_r484236334



##########
File path: pom.xml
##########
@@ -76,6 +76,7 @@
     <hive.version>${hive3.version}</hive.version>
     <pig.version>0.13.0</pig.version>
     <log4j.version>1.2.17</log4j.version>
+    <slf4j.version>1.6.4</slf4j.version>

Review comment:
       The version is already defined a few lines below this.
   Also, the slf4j version seems to be quite ancient, it should probably be synchronized to the main repo. (1.7.25)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-connectors] stoty closed pull request #29: PHOENIX-6103 Replace apache.commons.logging in Phoenix-Connectors

Posted by GitBox <gi...@apache.org>.
stoty closed pull request #29:
URL: https://github.com/apache/phoenix-connectors/pull/29


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org