You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/08/22 22:34:43 UTC

Review Request 71354: Added ResourceQuantities::fromScalarResource.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71354/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Bugs: MESOS-9806
    https://issues.apache.org/jira/browse/MESOS-9806


Repository: mesos


Description
-------

Master + previous patches:
*HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Made 3500 allocations in 24.15 secs
Made 0 allocation in 20.48 secs

Master + previous patches + this patch:
Master + this patch:
*HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Made 3500 allocations in 23.37 secs
Made 0 allocation in 19.72 secs


Diffs
-----

  include/mesos/resource_quantities.hpp c861df8a8a167b19ea8374c22cdd2a8fe567a6a6 
  src/common/resource_quantities.cpp 9577181bc4c05214759332e41f4a7d8b8fb6db1f 
  src/common/resources_utils.cpp 720b954b74a5db72438b1846d7df837d6a1fa4a4 


Diff: https://reviews.apache.org/r/71354/diff/1/


Testing
-------


Thanks,

Benjamin Mahler

Re: Review Request 71354: Added ResourceQuantities::fromScalarResource.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71354/#review217388
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On Aug. 22, 2019, 3:34 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71354/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2019, 3:34 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-9806
>     https://issues.apache.org/jira/browse/MESOS-9806
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Master + previous patches:
> *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> Made 3500 allocations in 24.15 secs
> Made 0 allocation in 20.48 secs
> 
> Master + previous patches + this patch:
> Master + this patch:
> *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> Made 3500 allocations in 23.37 secs
> Made 0 allocation in 19.72 secs
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_quantities.hpp c861df8a8a167b19ea8374c22cdd2a8fe567a6a6 
>   src/common/resource_quantities.cpp 9577181bc4c05214759332e41f4a7d8b8fb6db1f 
>   src/common/resources_utils.cpp 720b954b74a5db72438b1846d7df837d6a1fa4a4 
> 
> 
> Diff: https://reviews.apache.org/r/71354/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>