You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2007/12/19 00:09:43 UTC

[jira] Created: (HADOOP-2461) Configuration should trim property names and accept decimal, hexadecimal, and octal numbers

Configuration should trim property names and accept decimal, hexadecimal, and octal numbers
-------------------------------------------------------------------------------------------

                 Key: HADOOP-2461
                 URL: https://issues.apache.org/jira/browse/HADOOP-2461
             Project: Hadoop
          Issue Type: Improvement
          Components: conf
            Reporter: Tsz Wo (Nicholas), SZE
            Priority: Minor


I suggest two improvements in reading configuration:
- Suppose we have the following property in a conf file.
{code}
<property>
<name>
testing.property</name>
<value>something</value>
</property>
{code}
Try to get it by
{code}
Configuration conf = new Configuration();
String value = conf.get("testing.property"); //value == null here
{code}
We will get null since there is an eol in 
{code}
<name>
testing.property</name>
{code}
I suggest to trim all property names.

- I also suggest configuration to accept decimal, hexadecimal, and octal numbers (e.g. 011 is 9, 0xA is 10)
It can be easily done by replacing Integer.parseInt(...) with Integer.decode(...) in Configuration.getInt(...), similarly, in Configuration.getLong(...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2461) Configuration should trim property names and accept decimal, hexadecimal, and octal numbers

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2461:
-------------------------------------------

    Attachment: 2461_20071218.patch

If the suggestions are good, here is a patch.

> Configuration should trim property names and accept decimal, hexadecimal, and octal numbers
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2461
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2461
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 2461_20071218.patch
>
>
> I suggest two improvements in reading configuration:
> - Suppose we have the following property in a conf file.
> {code}
> <property>
> <name>
> testing.property</name>
> <value>something</value>
> </property>
> {code}
> Try to get it by
> {code}
> Configuration conf = new Configuration();
> String value = conf.get("testing.property"); //value == null here
> {code}
> We will get null since there is an eol in 
> {code}
> <name>
> testing.property</name>
> {code}
> I suggest to trim all property names.
> - I also suggest configuration to accept decimal, hexadecimal, and octal numbers (e.g. 011 is 9, 0xA is 10)
> It can be easily done by replacing Integer.parseInt(...) with Integer.decode(...) in Configuration.getInt(...), similarly, in Configuration.getLong(...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-2461) Configuration should trim property names and accept decimal, hexadecimal, and octal numbers

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE reassigned HADOOP-2461:
----------------------------------------------

    Assignee: Tsz Wo (Nicholas), SZE

> Configuration should trim property names and accept decimal, hexadecimal, and octal numbers
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2461
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2461
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 2461_20071218.patch
>
>
> I suggest two improvements in reading configuration:
> - Suppose we have the following property in a conf file.
> {code}
> <property>
> <name>
> testing.property</name>
> <value>something</value>
> </property>
> {code}
> Try to get it by
> {code}
> Configuration conf = new Configuration();
> String value = conf.get("testing.property"); //value == null here
> {code}
> We will get null since there is an eol in 
> {code}
> <name>
> testing.property</name>
> {code}
> I suggest to trim all property names.
> - I also suggest configuration to accept decimal, hexadecimal, and octal numbers (e.g. 011 is 9, 0xA is 10)
> It can be easily done by replacing Integer.parseInt(...) with Integer.decode(...) in Configuration.getInt(...), similarly, in Configuration.getLong(...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.