You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2025/10/14 01:47:02 UTC

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23535


Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................

IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Catalogd logs of GetPartialCatalogObject requests are not tagged with
correct query ids. Instead, the query id that is previously using that
thread is printed in the logs.

This is fixed by sending the query id in GetPartialCatalogObject
requests so catalogd can tag the responding thread with it.

Some codes are copied from Michael Smith's patch: https://gerrit.cloudera.org/c/22738/

Tested by enabling TRACE logging in org.apache.impala.common.JniUtil to
verify logs of GetPartialCatalogObject requests.

I20251014 09:39:39.685225 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID
I20251014 09:39:39.690346 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID. Time spent: 5ms
I20251014 09:39:39.699471 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional
I20251014 09:39:39.701821 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional. Time spent: 2ms
I20251014 09:39:39.711462 341074 TAcceptQueueServer.cpp:368] New connection to server CatalogService from client <Host: 127.0.0.1 Port: 42084>
I20251014 09:39:39.719146 342588 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of TABLE:functional.alltypestiny

Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
---
M be/src/catalog/catalog.cc
M be/src/service/fe-support.cc
M common/thrift/CatalogService.thrift
3 files changed, 18 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23535/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23535/5/be/src/service/fe-support.cc
File be/src/service/fe-support.cc:

http://gerrit.cloudera.org:8080/#/c/23535/5/be/src/service/fe-support.cc@595
PS5, Line 595:     // be addressed in IMPALA-12870.
> Is this still something we plan to do?
Yeah, I will work on that.



-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 22:46:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12569/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Oct 2025 02:17:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 4:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23535/4/be/src/catalog/catalog.cc
File be/src/catalog/catalog.cc:

http://gerrit.cloudera.org:8080/#/c/23535/4/be/src/catalog/catalog.cc@277
PS4, Line 277:   ScopedThreadContext scoped_tdi(DCHECK_NOTNULL(GetThreadDebugInfo()), req.header.query_id);
line too long (92 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 13:27:34 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23535/2/be/src/catalog/catalog.cc
File be/src/catalog/catalog.cc:

http://gerrit.cloudera.org:8080/#/c/23535/2/be/src/catalog/catalog.cc@277
PS2, Line 277: req.header.query_id
> I think it's fine. 'query_id' in TCatalogServiceRequestHeader is initialize
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 04:49:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Oct 2025 02:17:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12562/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 05:04:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23535/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23535/1//COMMIT_MSG@10
PS1, Line 10: Instead, the query id that is previously using that
            : thread is printed in the logs.
            : 
Is this is due to previous query calling SetQueryId in one of RPC handler and not unsetting it after it is out of scope?
Is it possible to make a scope like try-with-resources that can set and unset it?



-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 02:28:46 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12562/


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 10:45:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23535

to look at the new patch set (#5).

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................

IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Catalogd logs of GetPartialCatalogObject requests are not tagged with
correct query ids. Instead, the query id that is previously using that
thread is printed in the logs. This is fixed by using
ScopedThreadContext which resets the query id at the end of the RPC
code.

Add DCHECKs to make sure ThreadDebugInfo is initialized before being
used in Catalog methods. An instance is added in CatalogdMain() for
this.

This patch also adds the query id in GetPartialCatalogObject requests so
catalogd can tag the responding thread with it.

Some codes are copied from Michael Smith's patch: https://gerrit.cloudera.org/c/22738/

Tested by enabling TRACE logging in org.apache.impala.common.JniUtil to
verify logs of GetPartialCatalogObject requests.

I20251014 09:39:39.685225 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID
I20251014 09:39:39.690346 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID. Time spent: 5ms
I20251014 09:39:39.699471 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional
I20251014 09:39:39.701821 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional. Time spent: 2ms
I20251014 09:39:39.711462 341074 TAcceptQueueServer.cpp:368] New connection to server CatalogService from client <Host: 127.0.0.1 Port: 42084>
I20251014 09:39:39.719146 342588 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of TABLE:functional.alltypestiny

Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
---
M be/src/catalog/catalog.cc
M be/src/catalog/catalogd-main.cc
M be/src/service/fe-support.cc
M common/thrift/CatalogService.thrift
4 files changed, 37 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23535/5
-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 18:47:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Oct 2025 00:03:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Oct 2025 07:06:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23535/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23535/1//COMMIT_MSG@10
PS1, Line 10: Instead, the query id that is previously using that
            : thread is printed in the logs. This is fixed by using
            : 
> Is this is due to previous query calling SetQueryId in one of RPC handler a
Yeah, that makes sense! Changed the code to use ScopedThreadContext.



-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 03:09:58 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20674/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 03:34:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23535/2/be/src/catalog/catalog.cc
File be/src/catalog/catalog.cc:

http://gerrit.cloudera.org:8080/#/c/23535/2/be/src/catalog/catalog.cc@277
PS2, Line 277: req.header.query_id
> Just to confirm, is this ok to access without checking req.header.__isset.q
I think it's fine. 'query_id' in TCatalogServiceRequestHeader is initialized using the default constructor which sets its hi and lo numbers to 0. Here 'header' is a required field of TWaitForHmsEventRequest so we don't check it like other places.

In other places, we need to check if 'header' is set and construct a local variable 'query_id' before that. Checking 'req.header.__isset.query_id' is to avoid redundant assignment.



-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 04:44:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23535

to look at the new patch set (#4).

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................

IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Catalogd logs of GetPartialCatalogObject requests are not tagged with
correct query ids. Instead, the query id that is previously using that
thread is printed in the logs. This is fixed by using
ScopedThreadContext which resets the query id at the end of the RPC
code.

Add DCHECKs to make sure ThreadDebugInfo is initialized before being
used in Catalog methods. An instance is added in CatalogdMain() for
this.

This patch also adds the query id in GetPartialCatalogObject requests so
catalogd can tag the responding thread with it.

Some codes are copied from Michael Smith's patch: https://gerrit.cloudera.org/c/22738/

Tested by enabling TRACE logging in org.apache.impala.common.JniUtil to
verify logs of GetPartialCatalogObject requests.

I20251014 09:39:39.685225 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID
I20251014 09:39:39.690346 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID. Time spent: 5ms
I20251014 09:39:39.699471 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional
I20251014 09:39:39.701821 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional. Time spent: 2ms
I20251014 09:39:39.711462 341074 TAcceptQueueServer.cpp:368] New connection to server CatalogService from client <Host: 127.0.0.1 Port: 42084>
I20251014 09:39:39.719146 342588 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of TABLE:functional.alltypestiny

Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
---
M be/src/catalog/catalog.cc
M be/src/catalog/catalogd-main.cc
M be/src/service/fe-support.cc
M common/thrift/CatalogService.thrift
4 files changed, 36 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23535/4
-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23535/5/be/src/service/fe-support.cc
File be/src/service/fe-support.cc:

http://gerrit.cloudera.org:8080/#/c/23535/5/be/src/service/fe-support.cc@595
PS5, Line 595:     // be addressed in IMPALA-12870.
Is this still something we plan to do?



-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 15:55:42 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................

IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Catalogd logs of GetPartialCatalogObject requests are not tagged with
correct query ids. Instead, the query id that is previously using that
thread is printed in the logs. This is fixed by using
ScopedThreadContext which resets the query id at the end of the RPC
code.

Add DCHECKs to make sure ThreadDebugInfo is initialized before being
used in Catalog methods. An instance is added in CatalogdMain() for
this.

This patch also adds the query id in GetPartialCatalogObject requests so
catalogd can tag the responding thread with it.

Some codes are copied from Michael Smith's patch: https://gerrit.cloudera.org/c/22738/

Tested by enabling TRACE logging in org.apache.impala.common.JniUtil to
verify logs of GetPartialCatalogObject requests.

I20251014 09:39:39.685225 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID
I20251014 09:39:39.690346 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID. Time spent: 5ms
I20251014 09:39:39.699471 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional
I20251014 09:39:39.701821 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional. Time spent: 2ms
I20251014 09:39:39.711462 341074 TAcceptQueueServer.cpp:368] New connection to server CatalogService from client <Host: 127.0.0.1 Port: 42084>
I20251014 09:39:39.719146 342588 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of TABLE:functional.alltypestiny

Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Reviewed-on: http://gerrit.cloudera.org:8080/23535
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/catalog/catalog.cc
M be/src/catalog/catalogd-main.cc
M be/src/service/fe-support.cc
M common/thrift/CatalogService.thrift
4 files changed, 37 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 7
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20672/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 02:11:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23535/4/be/src/catalog/catalog.cc
File be/src/catalog/catalog.cc:

http://gerrit.cloudera.org:8080/#/c/23535/4/be/src/catalog/catalog.cc@277
PS4, Line 277:   ScopedThreadContext scoped_tdi(
> line too long (92 > 90)
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 13:59:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12564/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 14:00:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 05:04:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20678/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 14:24:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23535

to look at the new patch set (#2).

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................

IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Catalogd logs of GetPartialCatalogObject requests are not tagged with
correct query ids. Instead, the query id that is previously using that
thread is printed in the logs. This is fixed by using
ScopedThreadContext which resets the query id at the end of the RPC
code.

This patch also adds the query id in GetPartialCatalogObject requests so
catalogd can tag the responding thread with it.

Some codes are copied from Michael Smith's patch: https://gerrit.cloudera.org/c/22738/

Tested by enabling TRACE logging in org.apache.impala.common.JniUtil to
verify logs of GetPartialCatalogObject requests.

I20251014 09:39:39.685225 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID
I20251014 09:39:39.690346 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID. Time spent: 5ms
I20251014 09:39:39.699471 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional
I20251014 09:39:39.701821 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional. Time spent: 2ms
I20251014 09:39:39.711462 341074 TAcceptQueueServer.cpp:368] New connection to server CatalogService from client <Host: 127.0.0.1 Port: 42084>
I20251014 09:39:39.719146 342588 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of TABLE:functional.alltypestiny

Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
---
M be/src/catalog/catalog.cc
M be/src/service/fe-support.cc
M common/thrift/CatalogService.thrift
3 files changed, 33 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23535/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23535/2/be/src/catalog/catalog.cc
File be/src/catalog/catalog.cc:

http://gerrit.cloudera.org:8080/#/c/23535/2/be/src/catalog/catalog.cc@277
PS2, Line 277: req.header.query_id
Just to confirm, is this ok to access without checking req.header.__isset.query_id first, like the rest above?



-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 03:47:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )

Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20677/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 13:52:05 +0000
Gerrit-HasComments: No