You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/05/28 08:06:13 UTC
[GitHub] [incubator-doris] WingsGo opened a new pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
WingsGo opened a new pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713
The infomation is displayed in JSON format.For example:
` {"lastTabletReportTime":"N/A"} `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-637937165
> > The status mainly reflect BE's status, if some error happends, it should be FE's problem?Our mainly purpose is to monitoring BE's status, so maybe we can leave it to make sure that BE's status is OK?
>
> I remember this PR is to solve some problems that BE cannot report successfully because of the version out of data.
>
> If there are other problems in the reporting process, it is equivalent to this BE not reporting successfully. SO I think it should also be able to be reflected in this status field. We should focus on the final result, not the success or failure of a certain part of the entire reporting process.
>
> So actually, `lastTabletReportTime` means `lastSuccessTabletReportTime`
Ok, I change the logic and rename the filed name~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#discussion_r431672560
##########
File path: fe/src/main/java/org/apache/doris/system/Backend.java
##########
@@ -94,6 +94,9 @@
// this field is set by tablet report, and just for metric monitor, no need to persist.
private AtomicLong tabletMaxCompactionScore = new AtomicLong(0);
+ // additional backendStatus information for BE, display in JSON format
+ private BackendStatus backendStatus;
Review comment:
```suggestion
private BackendStatus backendStatus = new BackendStatus();
```
And remove all constructors below.
##########
File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java
##########
@@ -247,6 +249,13 @@ private static void tabletReport(long backendId, Map<Long, TTablet> backendTable
LOG.info("backend[{}] reports {} tablet(s). report version: {}",
backendId, backendTablets.size(), backendReportVersion);
+ final SystemInfoService currentSystemInfo = Catalog.getCurrentSystemInfo();
+ Backend reportBackend = currentSystemInfo.getBackend(backendId);
+ if (reportBackend != null) {
+ BackendStatus backendStatus = reportBackend.getBackendStatus();
+ backendStatus.lastTabletReportTime = TimeUtils.longToTimeString(start);
Review comment:
Better to create a method called `backend.updateStatus()` to set these infos.
Maybe we will add more info later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
WingsGo commented on a change in pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#discussion_r433871498
##########
File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java
##########
@@ -247,6 +249,13 @@ private static void tabletReport(long backendId, Map<Long, TTablet> backendTable
LOG.info("backend[{}] reports {} tablet(s). report version: {}",
backendId, backendTablets.size(), backendReportVersion);
+ final SystemInfoService currentSystemInfo = Catalog.getCurrentSystemInfo();
+ Backend reportBackend = currentSystemInfo.getBackend(backendId);
+ if (reportBackend != null) {
+ BackendStatus backendStatus = reportBackend.getBackendStatus();
+ backendStatus.lastTabletReportTime = TimeUtils.longToTimeString(start);
Review comment:
The status mainly reflect BE's status, if some error happends, it should be FE's problem?Our mainly purpose is to monitoring BE's status, so maybe we can leave it to make sure that BE's status is OK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
WingsGo commented on a change in pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#discussion_r433871498
##########
File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java
##########
@@ -247,6 +249,13 @@ private static void tabletReport(long backendId, Map<Long, TTablet> backendTable
LOG.info("backend[{}] reports {} tablet(s). report version: {}",
backendId, backendTablets.size(), backendReportVersion);
+ final SystemInfoService currentSystemInfo = Catalog.getCurrentSystemInfo();
+ Backend reportBackend = currentSystemInfo.getBackend(backendId);
+ if (reportBackend != null) {
+ BackendStatus backendStatus = reportBackend.getBackendStatus();
+ backendStatus.lastTabletReportTime = TimeUtils.longToTimeString(start);
Review comment:
The status mainly reflect BE's status, if some error happends, it should be FE's problem?Our mainly purpose is to monitoring BE's status, so maybe we can leave it to make sure that BE's status is OK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#discussion_r433857519
##########
File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java
##########
@@ -247,6 +249,13 @@ private static void tabletReport(long backendId, Map<Long, TTablet> backendTable
LOG.info("backend[{}] reports {} tablet(s). report version: {}",
backendId, backendTablets.size(), backendReportVersion);
+ final SystemInfoService currentSystemInfo = Catalog.getCurrentSystemInfo();
+ Backend reportBackend = currentSystemInfo.getBackend(backendId);
+ if (reportBackend != null) {
+ BackendStatus backendStatus = reportBackend.getBackendStatus();
+ backendStatus.lastTabletReportTime = TimeUtils.longToTimeString(start);
Review comment:
It ok, not a big deal.
Oh, I suggest to set this value right after the report in done, in case some other error happens during the report process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
imay merged pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-637454903
> Please update the doc `SHOW BACKENDS.md`, both in English and Chinese.
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-635186222
For #3698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
WingsGo commented on a change in pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#discussion_r431702383
##########
File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java
##########
@@ -247,6 +249,13 @@ private static void tabletReport(long backendId, Map<Long, TTablet> backendTable
LOG.info("backend[{}] reports {} tablet(s). report version: {}",
backendId, backendTablets.size(), backendReportVersion);
+ final SystemInfoService currentSystemInfo = Catalog.getCurrentSystemInfo();
+ Backend reportBackend = currentSystemInfo.getBackend(backendId);
+ if (reportBackend != null) {
+ BackendStatus backendStatus = reportBackend.getBackendStatus();
+ backendStatus.lastTabletReportTime = TimeUtils.longToTimeString(start);
Review comment:
if we need add more info, we can just add a new Field in `BackendStatus` and set the field's value, and new info will be shown in `show backends`, why we need to set the value and update the value?I think we can just set the value, and the new value will be shown when we use `show backends`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman edited a comment on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
morningman edited a comment on pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-637932239
> The status mainly reflect BE's status, if some error happends, it should be FE's problem?Our mainly purpose is to monitoring BE's status, so maybe we can leave it to make sure that BE's status is OK?
I remember this PR is to solve some problems that BE cannot report successfully because of the version out of data.
If there are other problems in the reporting process, it is equivalent to this BE not reporting successfully. SO I think it should also be able to be reflected in this status field. We should focus on the final result, not the success or failure of a certain part of the entire reporting process.
So actually, `lastTabletReportTime` means `lastSuccessTabletReportTime`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-637931102
The status mainly reflect BE's status, if some error happends, it should be FE's problem?Our mainly purpose is to monitoring BE's status, so maybe we can leave it to make sure that BE's status is OK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-637932239
> The status mainly reflect BE's status, if some error happends, it should be FE's problem?Our mainly purpose is to monitoring BE's status, so maybe we can leave it to make sure that BE's status is OK?
I remember this PR is to solve some problems that BE cannot report successfully because of the version out of data.
If there are other problems in the reporting process, it is equivalent to this BE not reporting successfully. SO I think it should also be able to be reflected in this status field. We should focus on the final result, not the success or failure of a certain part of the entire reporting process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org