You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/16 05:42:27 UTC
[GitHub] [hudi] danny0405 opened a new pull request, #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
danny0405 opened a new pull request, #5590:
URL: https://github.com/apache/hudi/pull/5590
…ter dispersion
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5590:
URL: https://github.com/apache/hudi/pull/5590#issuecomment-1127382653
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673",
"triggerID" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5590:
URL: https://github.com/apache/hudi/pull/5590#issuecomment-1127671910
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673",
"triggerID" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"triggerType" : "PUSH"
}, {
"hash" : "d43e0fbff85f12540575ed30551295b01f26806f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8681",
"triggerID" : "d43e0fbff85f12540575ed30551295b01f26806f",
"triggerType" : "PUSH"
}, {
"hash" : "f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8685",
"triggerID" : "f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673)
* d43e0fbff85f12540575ed30551295b01f26806f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8681)
* f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8685)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5590:
URL: https://github.com/apache/hudi/pull/5590#issuecomment-1127485438
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673",
"triggerID" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"triggerType" : "PUSH"
}, {
"hash" : "d43e0fbff85f12540575ed30551295b01f26806f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d43e0fbff85f12540575ed30551295b01f26806f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673)
* d43e0fbff85f12540575ed30551295b01f26806f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5590:
URL: https://github.com/apache/hudi/pull/5590#issuecomment-1127667451
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673",
"triggerID" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"triggerType" : "PUSH"
}, {
"hash" : "d43e0fbff85f12540575ed30551295b01f26806f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8681",
"triggerID" : "d43e0fbff85f12540575ed30551295b01f26806f",
"triggerType" : "PUSH"
}, {
"hash" : "f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673)
* d43e0fbff85f12540575ed30551295b01f26806f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8681)
* f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] LinMingQiang commented on a diff in pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
LinMingQiang commented on code in PR #5590:
URL: https://github.com/apache/hudi/pull/5590#discussion_r873411817
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketIndexPartitioner.java:
##########
@@ -39,8 +40,9 @@ public BucketIndexPartitioner(int bucketNum, String indexKeyFields) {
}
@Override
- public int partition(String key, int numPartitions) {
+ public int partition(HoodieKey key, int numPartitions) {
int curBucket = BucketIdentifier.getBucketId(key, indexKeyFields, bucketNum);
- return BucketIdentifier.mod(curBucket, numPartitions);
+ int globalHash = (key.getPartitionPath() + curBucket).hashCode();
Review Comment:
The result returned here may be negative, which may lead to the error 'java.lang.ArrayIndexOutOfBoundsException: Array index out of range: -27'.
int globalHash = (key.getPartitionPath() + curBucket).hashCode() & Integer.MAX_VALUE' should be here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5590:
URL: https://github.com/apache/hudi/pull/5590#discussion_r873708869
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketIndexPartitioner.java:
##########
@@ -39,8 +40,9 @@ public BucketIndexPartitioner(int bucketNum, String indexKeyFields) {
}
@Override
- public int partition(String key, int numPartitions) {
+ public int partition(HoodieKey key, int numPartitions) {
int curBucket = BucketIdentifier.getBucketId(key, indexKeyFields, bucketNum);
- return BucketIdentifier.mod(curBucket, numPartitions);
+ int globalHash = (key.getPartitionPath() + curBucket).hashCode();
Review Comment:
Cool, thanks for the review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5590:
URL: https://github.com/apache/hudi/pull/5590#issuecomment-1127489093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673",
"triggerID" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"triggerType" : "PUSH"
}, {
"hash" : "d43e0fbff85f12540575ed30551295b01f26806f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8681",
"triggerID" : "d43e0fbff85f12540575ed30551295b01f26806f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673)
* d43e0fbff85f12540575ed30551295b01f26806f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8681)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #5590:
URL: https://github.com/apache/hudi/pull/5590#issuecomment-1127818443
rebase this pr for CI's error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5590:
URL: https://github.com/apache/hudi/pull/5590#issuecomment-1127924818
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673",
"triggerID" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"triggerType" : "PUSH"
}, {
"hash" : "d43e0fbff85f12540575ed30551295b01f26806f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8681",
"triggerID" : "d43e0fbff85f12540575ed30551295b01f26806f",
"triggerType" : "PUSH"
}, {
"hash" : "f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8685",
"triggerID" : "f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8685)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5590:
URL: https://github.com/apache/hudi/pull/5590#issuecomment-1127741685
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673",
"triggerID" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"triggerType" : "PUSH"
}, {
"hash" : "d43e0fbff85f12540575ed30551295b01f26806f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8681",
"triggerID" : "d43e0fbff85f12540575ed30551295b01f26806f",
"triggerType" : "PUSH"
}, {
"hash" : "f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8685",
"triggerID" : "f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d43e0fbff85f12540575ed30551295b01f26806f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8681)
* f67a2edad7413c9fc574cf1f6d86bb7a42dd93f8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8685)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #5590:
URL: https://github.com/apache/hudi/pull/5590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5590:
URL: https://github.com/apache/hudi/pull/5590#issuecomment-1127263867
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673",
"triggerID" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8673)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5590: [HUDI-4101] BucketIndexPartitioner should take partition path for bet…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5590:
URL: https://github.com/apache/hudi/pull/5590#issuecomment-1127261227
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ce638e5bba2da5b47291cbe2ac6c35a0f542ee5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org