[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #1259: SAMZA-2444: JobModel save in CoordinatorStreamStore resulting flush for each message

[GitBox <gi...@apache.org>]

lakshmi-manasa-g commented on a change in pull request #1259: SAMZA-2444: JobModel save in CoordinatorStreamStore resulting flush for each message
URL: https://github.com/apache/samza/pull/1259#discussion_r371388096
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/coordinator/metadatastore/CoordinatorStreamStore.java
 ##########
 @@ -155,6 +156,15 @@ public void delete(String namespacedKey) {
     put(namespacedKey, null);
   }
 
+  @Override
+  public void deleteAll(Collection<String> namespacedKeys) {
+    Map<String, byte[]> entries = new HashMap<>(namespacedKeys.size());
+    for (String namespacedKey : namespacedKeys) {
+      entries.put(namespacedKey, null);
+    }
+    putAll(entries);
 
 Review comment:
   this is not atomic right. cause, the`flush()` is when the entries are guaranteed to be persisted on the coordinator stream and `putAll` does flush only at the end of all `put`. So if this is the expectation, then the MetadataStore interface should allow it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services