You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polaris.apache.org by di...@apache.org on 2026/09/24 19:45:43 UTC

(polaris) branch main updated: Map STS access denied to 403 (#5584)

This is an automated email from the ASF dual-hosted git repository.

dimas-b pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git


The following commit(s) were added to refs/heads/main by this push:
     new c6a42c4700 Map STS access denied to 403 (#5584)
c6a42c4700 is described below

commit c6a42c47007f1515308ff63cc3c4da392a2c7c7d
Author: fivetran-ashokborra <12...@users.noreply.github.com>
AuthorDate: Fri Sep 25 01:15:37 2026 +0530

    Map STS access denied to 403 (#5584)
    
    * fix(runtime): map STS access denied to 403
    
    * test(runtime): use status constants for STS mappings
    
    * test(runtime): cover STS status code mapping
---
 .../service/exception/IcebergExceptionMapper.java        |  3 +++
 .../service/exception/IcebergExceptionMapperTest.java    | 16 ++++++++++++++++
 2 files changed, 19 insertions(+)

diff --git a/runtime/service/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java b/runtime/service/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java
index 852af77fb8..60f4f665ce 100644
--- a/runtime/service/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java
+++ b/runtime/service/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java
@@ -63,6 +63,7 @@ import org.slf4j.LoggerFactory;
 import org.slf4j.event.Level;
 import software.amazon.awssdk.core.exception.SdkException;
 import software.amazon.awssdk.services.s3.model.S3Exception;
+import software.amazon.awssdk.services.sts.model.StsException;
 
 @Provider
 public class IcebergExceptionMapper implements ExceptionMapper<RuntimeException> {
@@ -211,6 +212,7 @@ public class IcebergExceptionMapper implements ExceptionMapper<RuntimeException>
   public static int extractHttpCodeFromCloudException(Throwable t) {
     return switch (t) {
       case S3Exception s3e -> s3e.statusCode();
+      case StsException stse -> stse.statusCode();
       case HttpResponseException hre -> hre.getResponse().getStatusCode();
       case StorageException se -> se.getCode();
       default -> UNKNOWN_CLOUD_HTTP_CODE;
@@ -226,6 +228,7 @@ public class IcebergExceptionMapper implements ExceptionMapper<RuntimeException>
    */
   static Optional<Integer> mapCloudExceptionToResponseCode(Throwable t) {
     if (!(t instanceof S3Exception
+        || t instanceof StsException
         || t instanceof AzureException
         || t instanceof StorageException)) {
       return Optional.empty();
diff --git a/runtime/service/src/test/java/org/apache/polaris/service/exception/IcebergExceptionMapperTest.java b/runtime/service/src/test/java/org/apache/polaris/service/exception/IcebergExceptionMapperTest.java
index 48c51109a6..3f5700461f 100644
--- a/runtime/service/src/test/java/org/apache/polaris/service/exception/IcebergExceptionMapperTest.java
+++ b/runtime/service/src/test/java/org/apache/polaris/service/exception/IcebergExceptionMapperTest.java
@@ -38,6 +38,7 @@ import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
 import software.amazon.awssdk.services.s3.model.S3Exception;
+import software.amazon.awssdk.services.sts.model.StsException;
 
 public class IcebergExceptionMapperTest {
 
@@ -68,6 +69,15 @@ public class IcebergExceptionMapperTest {
             Arguments.of(new AzureException("Not Authorized"), 403),
             Arguments.of(new AzureException("Access Denied"), 403),
             Arguments.of(S3Exception.builder().message("Access denied").build(), 403),
+            Arguments.of(
+                StsException.builder()
+                    .message("is not authorized to perform: sts:AssumeRole")
+                    .statusCode(Response.Status.FORBIDDEN.getStatusCode())
+                    .build(),
+                Response.Status.FORBIDDEN.getStatusCode()),
+            Arguments.of(
+                StsException.builder().message("Request failed").build(),
+                Response.Status.INTERNAL_SERVER_ERROR.getStatusCode()),
             Arguments.of(new StorageException(1, "access denied"), 403),
             Arguments.of(
                 new FileIOUnknownHostException(
@@ -89,6 +99,12 @@ public class IcebergExceptionMapperTest {
                                     .statusCode(entry.getKey())
                                     .build(),
                                 entry.getValue()),
+                            Arguments.of(
+                                StsException.builder()
+                                    .message("")
+                                    .statusCode(entry.getKey())
+                                    .build(),
+                                entry.getValue()),
                             Arguments.of(
                                 new StorageException(entry.getKey(), ""), entry.getValue()))
                         .flatMap(