[GitHub] [superset] rusackas commented on a diff in pull request #20874: fix(viz): Header scrolling for Time Table in dashboard

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #20874:
URL: https://github.com/apache/superset/pull/20874#discussion_r931428060


##########
superset-frontend/src/visualizations/TimeTable/TimeTable.jsx:
##########
@@ -98,12 +98,13 @@ const defaultProps = {
   url: '',
 };
 
+// @z-index-above-dashboard-charts + 1 = 11

Review Comment:
   FWIW, this is in the LESS codebase as `z-index-above-dashboard-charts` but obviously we're not using LESS here. This PR seems fine, but I wonder if we should make a levels/z-index registry in our Emotion theme. @michael-s-molina @eric-briscoe we might want to have a chat about how we can clean/support/scale these layers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org