You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "jtulach (via GitHub)" <gi...@apache.org> on 2023/05/02 16:20:41 UTC
[GitHub] [netbeans] jtulach opened a new pull request, #5910: Breakpoints in Scala sources in VSCode
jtulach opened a new pull request, #5910:
URL: https://github.com/apache/netbeans/pull/5910
As you may know I am working on [mixed Java+Scala codebase](https://github.com/enso-org/enso/). I have developed a NetBeans `.nbm` extension as well as `.vsix` file to support [our sbt based projects](https://github.com/enso-org/enso/tree/0778c850941348fc8fb83eb967f64b761de3743e/tools/enso4igv).
There is a special [ToggleScalaBreakpointActionProvider](https://github.com/enso-org/enso/blob/0778c850941348fc8fb83eb967f64b761de3743e/tools/enso4igv/src/main/java/org/enso/tools/enso4igv/scala/ToggleScalaBreakpointActionProvider.java) that handles breakpoints in Scala sources. It works great in NetBeans IDE. But I'd like it to work **in VSCode as well**!
This PR copies the code from [ToggleScalaBreakpointActionProvider](https://github.com/enso-org/enso/blob/0778c850941348fc8fb83eb967f64b761de3743e/tools/enso4igv/src/main/java/org/enso/tools/enso4igv/scala/ToggleScalaBreakpointActionProvider.java) (the license is Apache and I wrote it, so I can do it) and places it to `java.lsp.server`. That's [not modular at all](http://wiki.apidesign.org/wiki/Modularity) - but the `ActionProvider` doesn't seem to be consulted by the `java.lsp.server` - should that be fixed, I happily host my code in my [enso4igv extension](https://github.com/enso-org/enso/tree/0778c850941348fc8fb83eb967f64b761de3743e/tools/enso4igv).
@entlicher, how do we move foward? There is not much [modularity](http://wiki.apidesign.org/wiki/Modularity) in the `java.lsp.server` debugger breakpoint support - Java, Groovy, Truffle is all handled at a single place - can we add `.scala` as well? Or shall we seek a complete refactor and find a way to invoke `ActionProvider.toggleBreakpoint` action even from VSCode extension?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jtulach commented on pull request #5910: Breakpoints in Scala sources in VSCode
Posted by "jtulach (via GitHub)" <gi...@apache.org>.
jtulach commented on PR #5910:
URL: https://github.com/apache/netbeans/pull/5910#issuecomment-1573445769
The [PHP failure](https://github.com/apache/netbeans/actions/runs/4863454197/jobs/8671621042?pr=5910#step:27:3125) seems unrelated to my changes. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jtulach merged pull request #5910: Breakpoints in Scala sources in VSCode
Posted by "jtulach (via GitHub)" <gi...@apache.org>.
jtulach merged PR #5910:
URL: https://github.com/apache/netbeans/pull/5910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists