You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by ma...@apache.org on 2015/06/04 11:20:27 UTC

incubator-kylin git commit: KYLIN-808 fix dictionary bug

Repository: incubator-kylin
Updated Branches:
  refs/heads/0.8.0 503b958fa -> bc669d13d


KYLIN-808 fix dictionary bug


Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/bc669d13
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/bc669d13
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/bc669d13

Branch: refs/heads/0.8.0
Commit: bc669d13d3b41692eaf45d18ec4fdb19c82261d4
Parents: 503b958
Author: honma <ho...@ebay.com>
Authored: Thu Jun 4 17:20:12 2015 +0800
Committer: honma <ho...@ebay.com>
Committed: Thu Jun 4 17:20:12 2015 +0800

----------------------------------------------------------------------
 common/src/test/java/org/apache/kylin/common/util/BasicTest.java | 4 ++--
 .../src/main/java/org/apache/kylin/dict/DictionaryGenerator.java | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/bc669d13/common/src/test/java/org/apache/kylin/common/util/BasicTest.java
----------------------------------------------------------------------
diff --git a/common/src/test/java/org/apache/kylin/common/util/BasicTest.java b/common/src/test/java/org/apache/kylin/common/util/BasicTest.java
index 3bc4fda..b924ad5 100644
--- a/common/src/test/java/org/apache/kylin/common/util/BasicTest.java
+++ b/common/src/test/java/org/apache/kylin/common/util/BasicTest.java
@@ -77,9 +77,9 @@ public class BasicTest {
     @Test
     @Ignore("convenient trial tool for dev")
     public void test1() throws Exception {
-        System.out.println(org.apache.kylin.common.util.DateFormat.formatToTimeStr(1433250418000L));
+        System.out.println(org.apache.kylin.common.util.DateFormat.formatToTimeStr(1430438400000L));
         System.out.println(org.apache.kylin.common.util.DateFormat.formatToTimeStr(1433250517000L));
-        System.out.println(org.apache.kylin.common.util.DateFormat.stringToMillis("2015-06-02 13:05:00"));
+        System.out.println(org.apache.kylin.common.util.DateFormat.stringToMillis("2015-06-01 00:00:00"));
         System.out.println(org.apache.kylin.common.util.DateFormat.stringToMillis("2015-05-15 17:00:00"));
 
         String bb = "\\x00\\x00\\x00\\x00\\x01\\x3F\\xD0\\x2D\\58\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00";//2013/07/12 07:59:37

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/bc669d13/dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java
----------------------------------------------------------------------
diff --git a/dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java b/dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java
index 92d1705..7c1f808 100644
--- a/dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java
+++ b/dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java
@@ -117,7 +117,7 @@ public class DictionaryGenerator {
     }
 
     private static Dictionary buildDateTimeDict(Collection<byte[]> values, int baseId, int nSamples, ArrayList samples) {
-        final int BAD_THRESHOLD = 2;
+        final int BAD_THRESHOLD = 0;
         String matchPattern = null;
 
         for (String ptn : DATE_PATTERNS) {