[GitHub] [cordova-coho] raphinesse opened a new pull request #262: fix(gitutil): do not stash ignored files

[GitBox <gi...@apache.org>]

raphinesse opened a new pull request #262: fix(gitutil): do not stash ignored files
URL: https://github.com/apache/cordova-coho/pull/262
 
 
   Until now `gitutil.stashAndPop` ran the following command for each repo:
   
       git stash save --all --quiet "coho stash"
   
   Beside changed and untracked files, this also stashes ignored files. In
   our case that includes the `node_modules` folder. Due to the massive
   amount of files in there, that command takes a decent amount of time and
   can also lead to _a lot_ of CRLF warning messages, depending on your
   local git configuration.
   
   Furthermore, the new build system of `cordova-js` needs to have its
   dependencies present to be able to run. But since the `cordova-js` build
   is run in a `stashAndPop` block, all modules have been stashed and thus
   the build always fails.
   
   AFAICT, no invocation of `gitutil.stashAndPop` does actually _need_ to
   stash ignored files. Thus we can resolve these issues by replacing the
   `--all` flag with `--include-untracked`, giving us this command:
   
       git stash save --include-untracked --quiet "coho stash"
   
   This safely stashes all content that could potentially be destroyed by
   `coho` operations, while leaving ignored files in place.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org