svn commit: r412324 - in /maven/repository-manager/trunk: maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/ maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ maven-repository-proxy/src/main/java/org/apac...

[br...@apache.org]

Author: brett
Date: Wed Jun  7 01:19:57 2006
New Revision: 412324

URL: http://svn.apache.org/viewvc?rev=412324&view=rev
Log:
some more notes

Modified:
    maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java
    maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java
    maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
    maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java

Modified: maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java
URL: http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java?rev=412324&r1=412323&r2=412324&view=diff
==============================================================================
--- maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java (original)
+++ maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java Wed Jun  7 01:19:57 2006
@@ -47,7 +47,9 @@
 import java.util.StringTokenizer;
 
 /**
- * Implementation Class for searching through the index
+ * Implementation Class for searching through the index.
+ *
+ * @todo this is not a component, but extends ALE, meaning logging will throw an exception! -- should be a component
  */
 public class DefaultRepositoryIndexSearcher
     extends AbstractLogEnabled

Modified: maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java
URL: http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java?rev=412324&r1=412323&r2=412324&view=diff
==============================================================================
--- maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java (original)
+++ maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java Wed Jun  7 01:19:57 2006
@@ -23,6 +23,7 @@
 /**
  * @author Edwin Punzalan
  * @plexus.component role="org.apache.maven.repository.indexing.RepositoryIndexingFactory"
+ * @todo these methods should be replaced by plexus lookups of some kind!
  */
 public class DefaultRepositoryIndexingFactory
     implements RepositoryIndexingFactory

Modified: maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
URL: http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java?rev=412324&r1=412323&r2=412324&view=diff
==============================================================================
--- maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java (original)
+++ maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java Wed Jun  7 01:19:57 2006
@@ -53,6 +53,7 @@
  * @plexus.component role="org.apache.maven.repository.proxy.ProxyManager"
  * @todo too much of wagon manager is reproduced here because checksums need to be downloaded separately - is that necessary?
  * @todo this isn't reusing the parts of wagon manager than handle snapshots [!]
+ * @todo currently, cache must be in the same layout as the request, which prohibits any mapping
  */
 public class DefaultProxyManager
     extends AbstractLogEnabled

Modified: maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java
URL: http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java?rev=412324&r1=412323&r2=412324&view=diff
==============================================================================
--- maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java (original)
+++ maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java Wed Jun  7 01:19:57 2006
@@ -122,7 +122,10 @@
         return config;
     }
 
-    private void validateRemoteRepo( ProxyConfiguration configuration )
+    /**
+     * @todo should be shared with any other configuration loader - move method to configuration?
+     */
+    private static void validateRemoteRepo( ProxyConfiguration configuration )
         throws ValidationException
     {
         //Verify remote repository set
@@ -171,7 +174,10 @@
         return value;
     }
 
-    private void validateDirectories( ProxyConfiguration configuration )
+    /**
+     * @todo should be shared with any other configuration loader - move method to configuration?
+     */
+    private static void validateDirectories( ProxyConfiguration configuration )
         throws ValidationException
     {
         File f = new File( configuration.getRepositoryCachePath() );