[sparse directories] Non-recursive mode and 'info', 'propset', etc. APIs (was Re: svn commit: r26752 ...)

["Daniel L. Rall" <dl...@collab.net>]

On Sat, 22 Sep 2007, Hyrum K. Wright wrote:

> hwright@tigris.org wrote:
...
> > Log:
> > Extend depth parameter from svn_client_propset3() to JavaHL.  Followup to
> > r26745.
> > 
> > (Note: This adds another JavaHL test failure to the one already present.)
> 
> This test failure was present even if I just use the
> SVN_DEPTH_TO_RECURSE macro in SVNClient::propertySet() instead of
> pushing the depth parameter all the way through to the Java API.  I
> decided that getting JavaHL to build was of higher priority than
> immediately diagnosing the failing test.
... 
> testOODStatus(org.tigris.subversion.javahl.BasicTests)junit.framework.AssertionFailedError:
> commit item for
> file:///home/hwright/dev/svn-apache/subversion/bindings/javahl/test-work/repositories/basic_test4/iota
> not expected
 
After discussing this with Hyrum, I fixed this problem today in r26766.

This was caused by use of Depth.fromRecurse(), Java code with the same
behavior as that of the SVN_DEPTH_FROM_RECURSE() macro.  Both the 'propset'
and 'info' APIs were making use of this type of conversion, which maps
non-recursive modes to svn_depth_files, breaking backwards compatibility.
APIs of this type should instead map non-recursive to svn_depth_empty.

Are there more cases of this problem?