[GitHub] ivankelly commented on a change in pull request #1755: Configure Netty allocator in bookie and client

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #1755:  Configure Netty allocator in bookie and client 
URL: https://github.com/apache/bookkeeper/pull/1755#discussion_r228449352
 
 

 ##########
 File path: bookkeeper-server/pom.xml
 ##########
 @@ -37,6 +37,18 @@
         </exclusion>
       </exclusions>
     </dependency>
+    <dependency>
+      <groupId>org.apache.bookkeeper</groupId>
+      <artifactId>bookkeeper-common-allocator</artifactId>
+      <version>${project.parent.version}</version>
+      <exclusions>
+        <!-- exclude "netty-buffer" since "netty-all" already introduces it -->
 
 Review comment:
   Is everything that pulls in the allocator going to have to do this? It may be worth marking netty-buffer as provided in the allocator pom

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services