You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2019/01/17 15:13:07 UTC

[cordova-android] branch master updated: Fix requirements error messages for JDK 8 (#620)

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git


The following commit(s) were added to refs/heads/master by this push:
     new d9c08f1  Fix requirements error messages for JDK 8 (#620)
d9c08f1 is described below

commit d9c08f12a7bceb47ee97ca8ca0e75548e78f999d
Author: Chris Brody <ch...@gmail.com>
AuthorDate: Thu Jan 17 10:13:00 2019 -0500

    Fix requirements error messages for JDK 8 (#620)
---
 bin/templates/cordova/lib/check_reqs.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/templates/cordova/lib/check_reqs.js b/bin/templates/cordova/lib/check_reqs.js
index ec94022..141042d 100644
--- a/bin/templates/cordova/lib/check_reqs.js
+++ b/bin/templates/cordova/lib/check_reqs.js
@@ -203,7 +203,7 @@ module.exports.check_java = function () {
                 return match && match[1];
             }, () => {
                 var msg =
-                'Failed to run "javac -version", make sure that you have a JDK installed.\n' +
+                'Failed to run "javac -version", make sure that you have a JDK version 8 installed.\n' +
                 'You can get it from the following location:\n' +
                 'https://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html';
                 if (process.env['JAVA_HOME']) {
@@ -359,7 +359,7 @@ module.exports.run = function () {
         console.log('JAVA_HOME=' + process.env['JAVA_HOME']);
 
         if (!String(values[0]).startsWith('1.8.')) {
-            throw new CordovaError('Requirements check failed for JDK 1.8');
+            throw new CordovaError(`Requirements check failed for JDK 8 ('1.8.*')`);
         }
 
         if (!values[1]) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org