Re: [PR] [#1680] fix(server): only remove the HDFS files that written by server themself when application is purged for expired [incubator-uniffle]

["zuston (via GitHub)" <gi...@apache.org>]

zuston commented on code in PR #1681:
URL: https://github.com/apache/incubator-uniffle/pull/1681#discussion_r1594931876


##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/HadoopShuffleDeleteHandler.java:
##########
@@ -52,7 +56,7 @@ public void delete(String[] storageBasePaths, String appId, String user) {
       while (!isSuccess && times < retryMax) {
         try {
           FileSystem fileSystem = HadoopFilesystemProvider.getFilesystem(user, path, hadoopConf);
-          fileSystem.delete(path, true);
+          delete(fileSystem, path, shuffleServerId);

Review Comment:
   Do you having the global var to get the shuffleServerId ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org