You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/15 22:53:10 UTC

[GitHub] [kafka] vvcephei commented on a change in pull request #8673: KAFKA-9992: EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

vvcephei commented on a change in pull request #8673:
URL: https://github.com/apache/kafka/pull/8673#discussion_r426078986



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java
##########
@@ -314,8 +321,7 @@ private TopicsDeletedCondition(final Collection<String> topics) {
 
         @Override
         public boolean conditionMet() {
-            final Set<String> allTopics = new HashSet<>(JavaConverters.setAsJavaSetConverter(
-                brokers[0].kafkaServer().zkClient().getAllTopicsInCluster(false)).asJava());
+            final Set<String> allTopics = new HashSet<>(getAllTopics());

Review comment:
       It looks like we don’t need to make a copy here anymore




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org