You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by "Zowalla, Richard" <ri...@hs-heilbronn.de> on 2020/11/28 10:48:10 UTC
Java 11, Corba Dependencies & Questions related to the build itself
Hi all,
I was yesterday working on TOMEE-2324 in order to prepare the code base
to be build with Java 11, which is currently impossible as CORBA-
related dependencies were removed. We had a discussion on this on the mailing list a few months ago [1].
First, I went the road doing bytecode generation at build-time [2],
which works in principle but has some drawbacks related to reflection
access in production code as @rmannibucau identified in [2].
For this reason, I went another way on the road following the
suggestions. The idea in short: (1) Creating a SPI as abstraction layer
of the CORBA-related API classes, (2) keep it in SystemInstance, (3)
Use the SPI instead of reflection to access the related classes, (4)
register a concrete implementation via openejb event observers.
I have prepared a draft PR [3], which contains some open questions.
Would be happy, if someone could have a look at it and drop some
feedback, thoughts or answers related to my open questions.
The work on [3] lead to a full build using "mvn clean install -Pall-
adapters" as described in the README.
Question 1: Is this the correct way to conduct a full build including
all tests or should I rather use "mvn clean install" to validate my
changes?
Nevertheless, while doing this, I encountered serveral
ClassNotFoundExceptions (which are also present on the current Master
branch) related to a missing "cxf-rt-rs-sse" dependency and one issue
related to EclipseLink 2.7.4 in the tests of the examples. I tried to
fix this in [4], which looked quite good until it failed with four
embedded bval tck tests. I dropped the build output in a gist [5].
Question 2: Can someone point me to a location where documentation is
provided on how to run / debug this (embedded) bval tck tests? Or are
they known to fail?
Any feedback or answers are very welcome - have already learned a lot
about TomEE internals yesterday :D
Thanks in advance,
Richard Z.
[1] https://www.mail-archive.com/dev@tomee.apache.org/msg14097.html
[2] https://github.com/apache/tomee/pull/713
[3] https://github.com/apache/tomee/pull/721
[4] https://github.com/apache/tomee/pull/723
[5] https://gist.github.com/rzo1/50df989f7fe3c65b3c5482679261e42d
Re: Java 11, Corba Dependencies & Questions related to the build itself
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
On the TCK thing, I just sent a status, hopefully it helps.
For the mailing lists. I'll gather that for you and let you know
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Thu, Dec 10, 2020 at 2:23 PM Zowalla, Richard <
richard.zowalla@hs-heilbronn.de> wrote:
> Hi Jean-Louis
>
> thanks for your mail.
>
> (1) Yup, building with JDK11 (either via Jenkins or via GitHub Actions)
> to verify a PR would be indeed a great thing. If I can assists /
> support in any means, just give me a ping.
>
> (2) Joining the discussion would be indeed interesting. Maybe you can
> point me to the related list / mail thread or forum?
>
> (3) I already read the TCK setup guide on twitter (by dblevins) and
> have it on my stack to proceed with the setup on my dev machine. I also
> need to re-read the current progress of the TCK fun on the mailing list
> to get an overview. There was an overview link (to the TCK results) on
> the mailing list a few days ago. I guess the work itself is coordinated
> via jira?
>
> Thanks and Gruss
> Richard Z
>
> Am Donnerstag, den 10.12.2020, 14:08 +0100 schrieb Jean-Louis Monteiro:
> > Hi Richard,
> >
> > Thanks for the quick note. I have reviewed, merged and marked the
> > tickets
> > as solved.
> > Thanks again for the contribution.
> >
> > In regards to the other PR, I indeed have seen it.
> > What I'd like is to actually get a build set up on jenkins for JDK11
> > and
> > also be able to build the PRs so we could see what's the impact of
> > the PR.
> > The next step is obviously to run everything including the TCK under
> > JDK11.
> >
> > We are currently discussing Jakarta EE 9.1 with JDK11 support.
> > There are few challenges to solve, the narrow thing for EJB, the
> > Corba
> > stuff and few others.
> >
> > Aside from the heavy load the community is having to get the TCK done
> > and
> > certify both TomEE 8 on Jakarta EE 8 and TomEE 9 on Jakarta EE 9, I'm
> > not
> > sure I have the visibility today on what Jakarta EE 9.1 will be.
> >
> > We'll definitely be looking closely at your PR because it's a huge
> > and
> > great contribution for the future.
> > I would encourage you to also join the discussion on the Jakarta EE
> > 9.1 and
> > the Corba thing if you want.
> >
> > And of course, if you have some spare cycles, join the TCK fun ;-)
> >
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Thu, Dec 10, 2020 at 2:00 PM Zowalla, Richard <
> > richard.zowalla@hs-heilbronn.de> wrote:
> >
> > > Thanks for the effors in fixing various TCK test issues and stuff.
> > > I guess, that you are all low of time atm. Therefore, my mail isn't
> > > high priority or something.
> > >
> > > It is just a friendly reminder to bring the discussion from the
> > > Github
> > > PR to the mailiong list.
> > >
> > > I don't think it is mission critical or something and it can still
> > > wait
> > > some time, but the discussion would bring us some steps into the
> > > direction to build with jdk 11.
> > >
> > > Gruss
> > > Richard Z
> > >
> > > Am Samstag, den 28.11.2020, 10:48 +0000 schrieb Zowalla, Richard:
> > > > Hi all,
> > > >
> > > > I was yesterday working on TOMEE-2324 in order to prepare the
> > > > code
> > > > base
> > > > to be build with Java 11, which is currently impossible as CORBA-
> > > > related dependencies were removed. We had a discussion on this on
> > > > the
> > > > mailing list a few months ago [1].
> > > >
> > > > First, I went the road doing bytecode generation at build-time
> > > > [2],
> > > > which works in principle but has some drawbacks related to
> > > > reflection
> > > > access in production code as @rmannibucau identified in [2].
> > > >
> > > > For this reason, I went another way on the road following the
> > > > suggestions. The idea in short: (1) Creating a SPI as abstraction
> > > > layer
> > > > of the CORBA-related API classes, (2) keep it in SystemInstance,
> > > > (3)
> > > > Use the SPI instead of reflection to access the related classes,
> > > > (4)
> > > > register a concrete implementation via openejb event observers.
> > > >
> > > > I have prepared a draft PR [3], which contains some open
> > > > questions.
> > > > Would be happy, if someone could have a look at it and drop some
> > > > feedback, thoughts or answers related to my open questions.
> > > >
> > > > The work on [3] lead to a full build using "mvn clean install
> > > > -Pall-
> > > > adapters" as described in the README.
> > > >
> > > > Question 1: Is this the correct way to conduct a full build
> > > > including
> > > > all tests or should I rather use "mvn clean install" to validate
> > > > my
> > > > changes?
> > > >
> > > > Nevertheless, while doing this, I encountered serveral
> > > > ClassNotFoundExceptions (which are also present on the current
> > > > Master
> > > > branch) related to a missing "cxf-rt-rs-sse" dependency and one
> > > > issue
> > > > related to EclipseLink 2.7.4 in the tests of the examples. I
> > > > tried to
> > > > fix this in [4], which looked quite good until it failed with
> > > > four
> > > > embedded bval tck tests. I dropped the build output in a gist
> > > > [5].
> > > >
> > > > Question 2: Can someone point me to a location where
> > > > documentation is
> > > > provided on how to run / debug this (embedded) bval tck tests? Or
> > > > are
> > > > they known to fail?
> > > >
> > > > Any feedback or answers are very welcome - have already learned a
> > > > lot
> > > > about TomEE internals yesterday :D
> > > >
> > > > Thanks in advance,
> > > > Richard Z.
> > > >
> > > > [1]
> > > > https://www.mail-archive.com/dev@tomee.apache.org/msg14097.html
> > > > [2] https://github.com/apache/tomee/pull/713
> > > > [3] https://github.com/apache/tomee/pull/721
> > > > [4] https://github.com/apache/tomee/pull/723
> > > > [5] https://gist.github.com/rzo1/50df989f7fe3c65b3c5482679261e42d
> > > --
> > >
> > >
>
>
Re: Java 11, Corba Dependencies & Questions related to the build
itself
Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.
Hi Jean-Louis
thanks for your mail.
(1) Yup, building with JDK11 (either via Jenkins or via GitHub Actions)
to verify a PR would be indeed a great thing. If I can assists /
support in any means, just give me a ping.
(2) Joining the discussion would be indeed interesting. Maybe you can
point me to the related list / mail thread or forum?
(3) I already read the TCK setup guide on twitter (by dblevins) and
have it on my stack to proceed with the setup on my dev machine. I also
need to re-read the current progress of the TCK fun on the mailing list
to get an overview. There was an overview link (to the TCK results) on
the mailing list a few days ago. I guess the work itself is coordinated
via jira?
Thanks and Gruss
Richard Z
Am Donnerstag, den 10.12.2020, 14:08 +0100 schrieb Jean-Louis Monteiro:
> Hi Richard,
>
> Thanks for the quick note. I have reviewed, merged and marked the
> tickets
> as solved.
> Thanks again for the contribution.
>
> In regards to the other PR, I indeed have seen it.
> What I'd like is to actually get a build set up on jenkins for JDK11
> and
> also be able to build the PRs so we could see what's the impact of
> the PR.
> The next step is obviously to run everything including the TCK under
> JDK11.
>
> We are currently discussing Jakarta EE 9.1 with JDK11 support.
> There are few challenges to solve, the narrow thing for EJB, the
> Corba
> stuff and few others.
>
> Aside from the heavy load the community is having to get the TCK done
> and
> certify both TomEE 8 on Jakarta EE 8 and TomEE 9 on Jakarta EE 9, I'm
> not
> sure I have the visibility today on what Jakarta EE 9.1 will be.
>
> We'll definitely be looking closely at your PR because it's a huge
> and
> great contribution for the future.
> I would encourage you to also join the discussion on the Jakarta EE
> 9.1 and
> the Corba thing if you want.
>
> And of course, if you have some spare cycles, join the TCK fun ;-)
>
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Thu, Dec 10, 2020 at 2:00 PM Zowalla, Richard <
> richard.zowalla@hs-heilbronn.de> wrote:
>
> > Thanks for the effors in fixing various TCK test issues and stuff.
> > I guess, that you are all low of time atm. Therefore, my mail isn't
> > high priority or something.
> >
> > It is just a friendly reminder to bring the discussion from the
> > Github
> > PR to the mailiong list.
> >
> > I don't think it is mission critical or something and it can still
> > wait
> > some time, but the discussion would bring us some steps into the
> > direction to build with jdk 11.
> >
> > Gruss
> > Richard Z
> >
> > Am Samstag, den 28.11.2020, 10:48 +0000 schrieb Zowalla, Richard:
> > > Hi all,
> > >
> > > I was yesterday working on TOMEE-2324 in order to prepare the
> > > code
> > > base
> > > to be build with Java 11, which is currently impossible as CORBA-
> > > related dependencies were removed. We had a discussion on this on
> > > the
> > > mailing list a few months ago [1].
> > >
> > > First, I went the road doing bytecode generation at build-time
> > > [2],
> > > which works in principle but has some drawbacks related to
> > > reflection
> > > access in production code as @rmannibucau identified in [2].
> > >
> > > For this reason, I went another way on the road following the
> > > suggestions. The idea in short: (1) Creating a SPI as abstraction
> > > layer
> > > of the CORBA-related API classes, (2) keep it in SystemInstance,
> > > (3)
> > > Use the SPI instead of reflection to access the related classes,
> > > (4)
> > > register a concrete implementation via openejb event observers.
> > >
> > > I have prepared a draft PR [3], which contains some open
> > > questions.
> > > Would be happy, if someone could have a look at it and drop some
> > > feedback, thoughts or answers related to my open questions.
> > >
> > > The work on [3] lead to a full build using "mvn clean install
> > > -Pall-
> > > adapters" as described in the README.
> > >
> > > Question 1: Is this the correct way to conduct a full build
> > > including
> > > all tests or should I rather use "mvn clean install" to validate
> > > my
> > > changes?
> > >
> > > Nevertheless, while doing this, I encountered serveral
> > > ClassNotFoundExceptions (which are also present on the current
> > > Master
> > > branch) related to a missing "cxf-rt-rs-sse" dependency and one
> > > issue
> > > related to EclipseLink 2.7.4 in the tests of the examples. I
> > > tried to
> > > fix this in [4], which looked quite good until it failed with
> > > four
> > > embedded bval tck tests. I dropped the build output in a gist
> > > [5].
> > >
> > > Question 2: Can someone point me to a location where
> > > documentation is
> > > provided on how to run / debug this (embedded) bval tck tests? Or
> > > are
> > > they known to fail?
> > >
> > > Any feedback or answers are very welcome - have already learned a
> > > lot
> > > about TomEE internals yesterday :D
> > >
> > > Thanks in advance,
> > > Richard Z.
> > >
> > > [1]
> > > https://www.mail-archive.com/dev@tomee.apache.org/msg14097.html
> > > [2] https://github.com/apache/tomee/pull/713
> > > [3] https://github.com/apache/tomee/pull/721
> > > [4] https://github.com/apache/tomee/pull/723
> > > [5] https://gist.github.com/rzo1/50df989f7fe3c65b3c5482679261e42d
> > --
> >
> >
Re: Java 11, Corba Dependencies & Questions related to the build itself
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
Hi Richard,
Thanks for the quick note. I have reviewed, merged and marked the tickets
as solved.
Thanks again for the contribution.
In regards to the other PR, I indeed have seen it.
What I'd like is to actually get a build set up on jenkins for JDK11 and
also be able to build the PRs so we could see what's the impact of the PR.
The next step is obviously to run everything including the TCK under JDK11.
We are currently discussing Jakarta EE 9.1 with JDK11 support.
There are few challenges to solve, the narrow thing for EJB, the Corba
stuff and few others.
Aside from the heavy load the community is having to get the TCK done and
certify both TomEE 8 on Jakarta EE 8 and TomEE 9 on Jakarta EE 9, I'm not
sure I have the visibility today on what Jakarta EE 9.1 will be.
We'll definitely be looking closely at your PR because it's a huge and
great contribution for the future.
I would encourage you to also join the discussion on the Jakarta EE 9.1 and
the Corba thing if you want.
And of course, if you have some spare cycles, join the TCK fun ;-)
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Thu, Dec 10, 2020 at 2:00 PM Zowalla, Richard <
richard.zowalla@hs-heilbronn.de> wrote:
> Thanks for the effors in fixing various TCK test issues and stuff.
> I guess, that you are all low of time atm. Therefore, my mail isn't
> high priority or something.
>
> It is just a friendly reminder to bring the discussion from the Github
> PR to the mailiong list.
>
> I don't think it is mission critical or something and it can still wait
> some time, but the discussion would bring us some steps into the
> direction to build with jdk 11.
>
> Gruss
> Richard Z
>
> Am Samstag, den 28.11.2020, 10:48 +0000 schrieb Zowalla, Richard:
> > Hi all,
> >
> > I was yesterday working on TOMEE-2324 in order to prepare the code
> > base
> > to be build with Java 11, which is currently impossible as CORBA-
> > related dependencies were removed. We had a discussion on this on the
> > mailing list a few months ago [1].
> >
> > First, I went the road doing bytecode generation at build-time [2],
> > which works in principle but has some drawbacks related to reflection
> > access in production code as @rmannibucau identified in [2].
> >
> > For this reason, I went another way on the road following the
> > suggestions. The idea in short: (1) Creating a SPI as abstraction
> > layer
> > of the CORBA-related API classes, (2) keep it in SystemInstance, (3)
> > Use the SPI instead of reflection to access the related classes, (4)
> > register a concrete implementation via openejb event observers.
> >
> > I have prepared a draft PR [3], which contains some open questions.
> > Would be happy, if someone could have a look at it and drop some
> > feedback, thoughts or answers related to my open questions.
> >
> > The work on [3] lead to a full build using "mvn clean install -Pall-
> > adapters" as described in the README.
> >
> > Question 1: Is this the correct way to conduct a full build including
> > all tests or should I rather use "mvn clean install" to validate my
> > changes?
> >
> > Nevertheless, while doing this, I encountered serveral
> > ClassNotFoundExceptions (which are also present on the current Master
> > branch) related to a missing "cxf-rt-rs-sse" dependency and one issue
> > related to EclipseLink 2.7.4 in the tests of the examples. I tried to
> > fix this in [4], which looked quite good until it failed with four
> > embedded bval tck tests. I dropped the build output in a gist [5].
> >
> > Question 2: Can someone point me to a location where documentation is
> > provided on how to run / debug this (embedded) bval tck tests? Or are
> > they known to fail?
> >
> > Any feedback or answers are very welcome - have already learned a lot
> > about TomEE internals yesterday :D
> >
> > Thanks in advance,
> > Richard Z.
> >
> > [1] https://www.mail-archive.com/dev@tomee.apache.org/msg14097.html
> > [2] https://github.com/apache/tomee/pull/713
> > [3] https://github.com/apache/tomee/pull/721
> > [4] https://github.com/apache/tomee/pull/723
> > [5] https://gist.github.com/rzo1/50df989f7fe3c65b3c5482679261e42d
> --
>
>
Re: Java 11, Corba Dependencies & Questions related to the build
itself
Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.
Thanks for the effors in fixing various TCK test issues and stuff.
I guess, that you are all low of time atm. Therefore, my mail isn't
high priority or something.
It is just a friendly reminder to bring the discussion from the Github
PR to the mailiong list.
I don't think it is mission critical or something and it can still wait
some time, but the discussion would bring us some steps into the
direction to build with jdk 11.
Gruss
Richard Z
Am Samstag, den 28.11.2020, 10:48 +0000 schrieb Zowalla, Richard:
> Hi all,
>
> I was yesterday working on TOMEE-2324 in order to prepare the code
> base
> to be build with Java 11, which is currently impossible as CORBA-
> related dependencies were removed. We had a discussion on this on the
> mailing list a few months ago [1].
>
> First, I went the road doing bytecode generation at build-time [2],
> which works in principle but has some drawbacks related to reflection
> access in production code as @rmannibucau identified in [2].
>
> For this reason, I went another way on the road following the
> suggestions. The idea in short: (1) Creating a SPI as abstraction
> layer
> of the CORBA-related API classes, (2) keep it in SystemInstance, (3)
> Use the SPI instead of reflection to access the related classes, (4)
> register a concrete implementation via openejb event observers.
>
> I have prepared a draft PR [3], which contains some open questions.
> Would be happy, if someone could have a look at it and drop some
> feedback, thoughts or answers related to my open questions.
>
> The work on [3] lead to a full build using "mvn clean install -Pall-
> adapters" as described in the README.
>
> Question 1: Is this the correct way to conduct a full build including
> all tests or should I rather use "mvn clean install" to validate my
> changes?
>
> Nevertheless, while doing this, I encountered serveral
> ClassNotFoundExceptions (which are also present on the current Master
> branch) related to a missing "cxf-rt-rs-sse" dependency and one issue
> related to EclipseLink 2.7.4 in the tests of the examples. I tried to
> fix this in [4], which looked quite good until it failed with four
> embedded bval tck tests. I dropped the build output in a gist [5].
>
> Question 2: Can someone point me to a location where documentation is
> provided on how to run / debug this (embedded) bval tck tests? Or are
> they known to fail?
>
> Any feedback or answers are very welcome - have already learned a lot
> about TomEE internals yesterday :D
>
> Thanks in advance,
> Richard Z.
>
> [1] https://www.mail-archive.com/dev@tomee.apache.org/msg14097.html
> [2] https://github.com/apache/tomee/pull/713
> [3] https://github.com/apache/tomee/pull/721
> [4] https://github.com/apache/tomee/pull/723
> [5] https://gist.github.com/rzo1/50df989f7fe3c65b3c5482679261e42d
--