[GitHub] [dubbo-go] zouyx commented on a change in pull request #730: Mod: Remove unnecessary return and judgement.

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r479602165



##########
File path: config/base_config.go
##########
@@ -22,15 +22,10 @@ import (
 	"reflect"
 	"strconv"
 	"strings"
-)
-
-import (
-	perrors "github.com/pkg/errors"
-)
 
-import (
 	"github.com/apache/dubbo-go/common/config"
 	"github.com/apache/dubbo-go/common/logger"
+	perrors "github.com/pkg/errors"

Review comment:
       Still wrong style

##########
File path: filter/filter_impl/access_log_filter.go
##########
@@ -23,9 +23,7 @@ import (
 	"reflect"
 	"strings"
 	"time"
-)

Review comment:
       recover it

##########
File path: config/reference_config.go
##########
@@ -23,20 +23,16 @@ import (
 	"net/url"
 	"strconv"
 	"time"
-)
 
-import (
 	"github.com/creasty/defaults"
-	gxstrings "github.com/dubbogo/gost/strings"
-)
 
-import (
 	"github.com/apache/dubbo-go/cluster/directory"
 	"github.com/apache/dubbo-go/common"
 	"github.com/apache/dubbo-go/common/constant"
 	"github.com/apache/dubbo-go/common/extension"
 	"github.com/apache/dubbo-go/common/proxy"
 	"github.com/apache/dubbo-go/protocol"
+	gxstrings "github.com/dubbogo/gost/strings"

Review comment:
       still wrong style

##########
File path: protocol/rest/rest_exporter.go
##########
@@ -19,9 +19,7 @@ package rest
 
 import (
 	"sync"
-)

Review comment:
       as above

##########
File path: remoting/zookeeper/curator_discovery/service_discovery.go
##########
@@ -22,18 +22,14 @@ import (
 	"path"
 	"strings"
 	"sync"
-)
 
-import (

Review comment:
       recover all import style in this file

##########
File path: registry/protocol/protocol.go
##########
@@ -21,23 +21,21 @@ import (
 	"context"
 	"strings"
 	"sync"
-)

Review comment:
       recover all import style in this file




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org