You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Brock Noland <br...@cloudera.com> on 2012/09/08 16:02:33 UTC

Review Request: FLUME-1543: TestFileChannel should be factored into many tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6968/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Breaks up TestFileChannel into several classes


This addresses bug FLUME-1543.
    https://issues.apache.org/jira/browse/FLUME-1543


Diffs
-----

  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java e2abc27 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java PRE-CREATION 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelFormatRegression.java PRE-CREATION 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java PRE-CREATION 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRollback.java PRE-CREATION 

Diff: https://reviews.apache.org/r/6968/diff/


Testing
-------

unit tests pass


Thanks,

Brock Noland


Re: Review Request: FLUME-1543: TestFileChannel should be factored into many tests

Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6968/#review11206
-----------------------------------------------------------

Ship it!


Ship It!

- Mike Percy


On Sept. 8, 2012, 2:02 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6968/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2012, 2:02 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Breaks up TestFileChannel into several classes
> 
> 
> This addresses bug FLUME-1543.
>     https://issues.apache.org/jira/browse/FLUME-1543
> 
> 
> Diffs
> -----
> 
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java e2abc27 
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java PRE-CREATION 
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelFormatRegression.java PRE-CREATION 
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java PRE-CREATION 
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRollback.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6968/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass
> 
> 
> Thanks,
> 
> Brock Noland
> 
>