Re: [PR] perf: Optimize decimal precision check in decimal aggregates (sum and avg) [datafusion-comet]

["kazuyukitanimura (via GitHub)" <gi...@apache.org>]

kazuyukitanimura commented on code in PR #952:
URL: https://github.com/apache/datafusion-comet/pull/952#discussion_r1772046900


##########
native/core/src/execution/datafusion/expressions/sum_decimal.rs:
##########
@@ -127,19 +127,22 @@ impl AggregateUDFImpl for SumDecimal {
     fn reverse_expr(&self) -> ReversedUDAF {
         ReversedUDAF::Identical
     }
+
+    fn is_nullable(&self) -> bool {
+        // SumDecimal is always nullable because overflows can cause null values

Review Comment:
   Wondering if this is true for ANSI.
   It looks the previous code is also hardcoding true, but this may be a good time to file an issue if there is not yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org