You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by eminency <gi...@git.apache.org> on 2014/09/24 07:32:28 UTC
[GitHub] tajo pull request: Tajo-668: Add datetime function documentation
GitHub user eminency opened a pull request:
https://github.com/apache/tajo/pull/160
Tajo-668: Add datetime function documentation
Like a kind of first draft...
Review in depth. It's much and rough.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eminency/tajo TAJO-668_datetime_func_doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit d7c16ae68bfefd056561f28cfa1c67f2c823a585
Author: Jongyoung Park <em...@gmail.com>
Date: 2014-09-24T05:05:40Z
Datetime function document added
commit f3629d25fd03b056a7101273f9e013029cc4029e
Author: Jongyoung Park <em...@gmail.com>
Date: 2014-09-24T05:12:20Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-668_datetime_func_doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Tajo-668: Add datetime function documentation
Posted by eminency <gi...@git.apache.org>.
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/160#issuecomment-56766398
@hyunsik ,
Especially it means last part about conversion and formatting.
Like you said, it is almost quoted from PostgresSQL documentation. But I couldn't test for all features though I tested other basic examples. So I couldn't guarantee documentation contents because I don't have full knowledge of tajo datetime function implementation.
If there is no difference in actual datetime implementation between Tajo and Pgsql, I think it may be OK that you glance it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Tajo-668: Add datetime function documentation
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/160#issuecomment-57561613
For date/time conversion and formatting, we ported pgsql's implementation to Tajo. So, most of all features are compatible between Tajo and pgsql. So, it would be Ok.
@babokim could you look over this documentation? Because you contributed this feature, you may be the best reviewer on this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Tajo-668: Add datetime function documentation
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/160#issuecomment-56760336
Your patch includes some of Postgresql documentation. We already noticed that Tajo includes PostgreSQL. The license of PostgreSQL is compatible with ASF 2.0. In my view, the documentation looks good to me.
You said the documentation is rough. Could you let me know what parts do you want us to review intensively?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Tajo-668: Add datetime function documentation
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/160#issuecomment-57923232
+1 I'll commit it soon.
If we find something to be revise later, we can make additional jira and patch at that time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Tajo-668: Add datetime function documentation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---