You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/02 05:22:34 UTC
[GitHub] [kafka] chia7712 commented on a change in pull request #10206: KAFKA-12369; Implement `ListTransactions` API
chia7712 commented on a change in pull request #10206:
URL: https://github.com/apache/kafka/pull/10206#discussion_r585252099
##########
File path: clients/src/main/resources/common/message/ListTransactionsResponse.json
##########
@@ -0,0 +1,35 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ "apiKey": 66,
+ "type": "response",
+ "name": "ListTransactionsResponse",
+ "validVersions": "0",
+ "flexibleVersions": "0+",
+ "fields": [
+ { "name": "ThrottleTimeMs", "type": "int32", "versions": "0+",
+ "about": "The duration in milliseconds for which the request was throttled due to a quota violation, or zero if the request did not violate any quota." },
+ { "name": "ErrorCode", "type": "int16", "versions": "0+" },
+ { "name": "UnknownStateFilters", "type": "[]string", "default": "null", "versions": "0+", "nullableVersions": "0+",
Review comment:
the name in request is called `StatesFilter`. Could you make consistent naming?
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -3303,6 +3304,28 @@ class KafkaApis(val requestChannel: RequestChannel,
new DescribeTransactionsResponse(response.setThrottleTimeMs(requestThrottleMs)))
}
+ def handleListTransactionsRequest(request: RequestChannel.Request): Unit = {
+ val listTransactionsRequest = request.body[ListTransactionsRequest]
+ val filteredProducerIds = listTransactionsRequest.data.producerIdFilter.asScala.map(Long.unbox).toSet
+ val filteredStates = listTransactionsRequest.data.statesFilter.asScala.toSet
+ val response = txnCoordinator.handleListTransactions(filteredProducerIds, filteredStates)
+
+ // The response should contain only transactionalIds that the principal
+ // has `Describe` permission to access.
+ if (response.transactionStates != null) {
Review comment:
Is this null check necessary? the filed is NOT nullable. There appears to be a bug if we set null to it in production code.
##########
File path: clients/src/main/resources/common/message/ListTransactionsResponse.json
##########
@@ -0,0 +1,35 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ "apiKey": 66,
+ "type": "response",
+ "name": "ListTransactionsResponse",
+ "validVersions": "0",
+ "flexibleVersions": "0+",
+ "fields": [
+ { "name": "ThrottleTimeMs", "type": "int32", "versions": "0+",
+ "about": "The duration in milliseconds for which the request was throttled due to a quota violation, or zero if the request did not violate any quota." },
+ { "name": "ErrorCode", "type": "int16", "versions": "0+" },
+ { "name": "UnknownStateFilters", "type": "[]string", "default": "null", "versions": "0+", "nullableVersions": "0+",
Review comment:
Why it requires `nullableVersions`?
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -3303,6 +3304,28 @@ class KafkaApis(val requestChannel: RequestChannel,
new DescribeTransactionsResponse(response.setThrottleTimeMs(requestThrottleMs)))
}
+ def handleListTransactionsRequest(request: RequestChannel.Request): Unit = {
+ val listTransactionsRequest = request.body[ListTransactionsRequest]
+ val filteredProducerIds = listTransactionsRequest.data.producerIdFilter.asScala.map(Long.unbox).toSet
+ val filteredStates = listTransactionsRequest.data.statesFilter.asScala.toSet
+ val response = txnCoordinator.handleListTransactions(filteredProducerIds, filteredStates)
+
+ // The response should contain only transactionalIds that the principal
+ // has `Describe` permission to access.
+ if (response.transactionStates != null) {
+ val transactionStateIter = response.transactionStates.iterator()
+ while (transactionStateIter.hasNext) {
Review comment:
How about checking permission of cluster first? It can avoiding redundant loops.
##########
File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala
##########
@@ -223,6 +224,63 @@ class TransactionStateManager(brokerId: Int,
throw new IllegalStateException(s"Unexpected empty transaction metadata returned while putting $txnMetadata")))
}
+ def listTransactionStates(
+ filterProducerIds: Set[Long],
+ filterStateNames: Set[String]
+ ): ListTransactionsResponseData = {
+ inReadLock(stateLock) {
+ val response = new ListTransactionsResponseData()
+ if (loadingPartitions.nonEmpty) {
+ response.setErrorCode(Errors.COORDINATOR_LOAD_IN_PROGRESS.code)
+ } else {
+ val filterStates = mutable.Set.empty[TransactionState]
+ val unknownStates = new java.util.ArrayList[String]
+ filterStateNames.foreach { stateName =>
+ TransactionState.fromName(stateName) match {
+ case Some(state) => filterStates += state
+ case None => unknownStates.add(stateName)
Review comment:
It response#unknownStates is NOT nullable, we can simplify it to `case None => response.unknownStateFilters().add(stateName)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org