You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Kočí (JIRA)" <de...@myfaces.apache.org> on 2011/08/05 20:31:27 UTC

[jira] [Created] (MYFACES-3266) [perf] [concurrency] check correct logger creation

[perf] [concurrency] check correct logger creation
--------------------------------------------------

                 Key: MYFACES-3266
                 URL: https://issues.apache.org/jira/browse/MYFACES-3266
             Project: MyFaces Core
          Issue Type: Improvement
            Reporter: Martin Kočí
            Assignee: Martin Kočí
            Priority: Trivial


<BLOCKED>java.util.logging.Logger.getLogger(String)
   javax.faces.component.UIViewRoot.<init>()

problem is that has non-static logger  and logger is requested in every view init. For a class (static) method, the monitor associated with the Class object for the method's class is used. 

Check myfaces code base for this usage.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (MYFACES-3266) [perf] [concurrency] check correct logger creation

Posted by "Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184685#comment-13184685 ] 

Leonardo Uribe commented on MYFACES-3266:
-----------------------------------------

Attached patch with proposed solution. The idea is call it only when it is necessary. If no objections I'll commit this code soon.
                
> [perf] [concurrency] check correct logger creation
> --------------------------------------------------
>
>                 Key: MYFACES-3266
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3266
>             Project: MyFaces Core
>          Issue Type: Improvement
>            Reporter: Martin Kočí
>            Assignee: Martin Kočí
>            Priority: Trivial
>         Attachments: MYFACES-3266-1.patch
>
>
> <BLOCKED>java.util.logging.Logger.getLogger(String)
>    javax.faces.component.UIViewRoot.<init>()
> problem is that has non-static logger  and logger is requested in every view init. For a class (static) method, the monitor associated with the Class object for the method's class is used. 
> Check myfaces code base for this usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (MYFACES-3266) [perf] [concurrency] check correct logger creation

Posted by "Leonardo Uribe (Updated) (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe updated MYFACES-3266:
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.6
                   2.0.12
         Assignee: Leonardo Uribe  (was: Martin Kočí)
           Status: Resolved  (was: Patch Available)
    
> [perf] [concurrency] check correct logger creation
> --------------------------------------------------
>
>                 Key: MYFACES-3266
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3266
>             Project: MyFaces Core
>          Issue Type: Improvement
>            Reporter: Martin Kočí
>            Assignee: Leonardo Uribe
>            Priority: Trivial
>             Fix For: 2.0.12, 2.1.6
>
>         Attachments: MYFACES-3266-1.patch
>
>
> <BLOCKED>java.util.logging.Logger.getLogger(String)
>    javax.faces.component.UIViewRoot.<init>()
> problem is that has non-static logger  and logger is requested in every view init. For a class (static) method, the monitor associated with the Class object for the method's class is used. 
> Check myfaces code base for this usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (MYFACES-3266) [perf] [concurrency] check correct logger creation

Posted by "Leonardo Uribe (Updated) (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe updated MYFACES-3266:
------------------------------------

    Status: Patch Available  (was: Open)
    
> [perf] [concurrency] check correct logger creation
> --------------------------------------------------
>
>                 Key: MYFACES-3266
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3266
>             Project: MyFaces Core
>          Issue Type: Improvement
>            Reporter: Martin Kočí
>            Assignee: Martin Kočí
>            Priority: Trivial
>         Attachments: MYFACES-3266-1.patch
>
>
> <BLOCKED>java.util.logging.Logger.getLogger(String)
>    javax.faces.component.UIViewRoot.<init>()
> problem is that has non-static logger  and logger is requested in every view init. For a class (static) method, the monitor associated with the Class object for the method's class is used. 
> Check myfaces code base for this usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira