[jira] [Commented] (DRILL-8069) remove use of excel sheet getLastRowNum

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454443#comment-17454443 ] 

ASF GitHub Bot commented on DRILL-8069:
---------------------------------------

pjfanning opened a new pull request #2396:
URL: https://github.com/apache/drill/pull/2396


   # [DRILL-8069](https://issues.apache.org/jira/browse/DRILL-8069): remove use of excel sheet getLastRowNum
   
   ## Description
   It is not guaranteed that getLastRowNum will return the right data - it depends on dimension data that excel saves in the sheet XML but it seems increasingly common for this to be omitted
   
   ## Documentation
   None
   
   ## Testing
   Unit tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> remove use of excel sheet getLastRowNum
> ---------------------------------------
>
>                 Key: DRILL-8069
>                 URL: https://issues.apache.org/jira/browse/DRILL-8069
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Data Types
>            Reporter: PJ Fanning
>            Priority: Major
>
> excel-streaming-reader can only get last row num from sheets that have dimension data and not all sheets have this set - it is safer to iterate through the row data and not try to shortcut the reading of the sheet based on getLastRowNum



--
This message was sent by Atlassian Jira
(v8.20.1#820001)