You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "TanYuxin-tyx (via GitHub)" <gi...@apache.org> on 2023/11/02 03:10:53 UTC
[PR] [FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 [flink-shaded]
TanYuxin-tyx opened a new pull request, #127:
URL: https://github.com/apache/flink-shaded/pull/127
This is for https://issues.apache.org/jira/browse/FLINK-33417.
In our ARM environment, we encounter a compile error when using Flink 1.17.
Flink 1.17 depends on flink-shaded 16.1, which uses netty 4.1.82. However, flink-shaded 16.1 fails to compile in the ARM environment. As a result, we are unable to compile Flink 1.17 due to this issue.
We have tested compiling flink-shaded using netty 4.1.83 or a later version in ARM env, and it can compile successfully.
Taking into consideration the previous discussions regarding compatibility and the dependency of external connectors on this version, I propose addressing the bug by only updating flink-shaded's netty to a minor version (e.g., 4.1.83) rather than backporting [FLINK-32032](https://issues.apache.org/jira/browse/FLINK-32032).
To implement the update, maybe a new release of flink-shaded 16.2 needs to be released.
The discussion details is at https://lists.apache.org/thread/y1c8545bcsx2836d9pgfdzj65knvw7kb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 [flink-shaded]
Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on PR #127:
URL: https://github.com/apache/flink-shaded/pull/127#issuecomment-1792105273
@XComp Thanks a lot for your investigation and the careful review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 [flink-shaded]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #127:
URL: https://github.com/apache/flink-shaded/pull/127#issuecomment-1791964077
Thanks @reswqa for verifying the PR as well. There's a discussion ongoing in FLINK-33417. I'm gonna wait with merging this change until the last questions are answered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 [flink-shaded]
Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on PR #127:
URL: https://github.com/apache/flink-shaded/pull/127#issuecomment-1790378424
ok. I have only the screenshots of the error, unfortunately, I do not have any links to provide.
I have attached these screenshots to the Jira(https://issues.apache.org/jira/browse/FLINK-33417).
The BE20xxx pic is the error when using 4.1.82. The 09DDxx pic is the pic of compiling successfully after using 4.1.83.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 [flink-shaded]
Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on PR #127:
URL: https://github.com/apache/flink-shaded/pull/127#issuecomment-1790287316
> you don't have, by any chance, links to the referenced CI runs which you could share here as well?
@XComp Thanks a lot for the quick review.
The CI is here https://github.com/apache/flink-shaded/actions/runs/6727989844.
Because this is my first PR to this repo, the CI was not triggered automatically when opening it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 [flink-shaded]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #127:
URL: https://github.com/apache/flink-shaded/pull/127#issuecomment-1792100017
I merged the PR after a final investigation. The results of the investigation are collected in [FLINK-33417](https://issues.apache.org/jira/browse/FLINK-33417?focusedCommentId=17782476&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17782476). Thanks for your patience @TanYuxin-tyx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 [flink-shaded]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #127:
URL: https://github.com/apache/flink-shaded/pull/127#issuecomment-1791968810
> I'm gonna wait with merging this change until the last questions are answered.
Yes, make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 [flink-shaded]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #127:
URL: https://github.com/apache/flink-shaded/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 [flink-shaded]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #127:
URL: https://github.com/apache/flink-shaded/pull/127#issuecomment-1790216614
thanks @TanYuxin-tyx - you don't have, by any chance, links to the referenced CI runs which you could share here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 [flink-shaded]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #127:
URL: https://github.com/apache/flink-shaded/pull/127#issuecomment-1790316431
Sorry for not being that clear. I meant the ARM compilation error you mentioned in the PR description:
{quote}
In our ARM environment, we encounter a compile error when using Flink 1.17.
{quote}
I was wondering whether there would be a link to the failure and a link to a run that succeeded with this fix being applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org