You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/08/26 13:09:48 UTC
[GitHub] jlahoda commented on a change in pull request #790: Enable JDK
matrix in Travis
jlahoda commented on a change in pull request #790: Enable JDK matrix in Travis
URL: https://github.com/apache/incubator-netbeans/pull/790#discussion_r212825757
##########
File path: nbbuild/templates/common.xml
##########
@@ -65,7 +65,7 @@
<condition property="javahelp.class.path.extension" value="docs/${javahelp.jar.basename}">
<isset property="has.javahelp"/>
</condition>
- <property name="javac.source" value="1.4"/>
+ <property name="javac.source" value="1.6"/>
Review comment:
I guess I'd suggest to use at least 1.7 as a default. 1.7 is not supported under JDK 12, see:
http://hg.openjdk.java.net/jdk/jdk/rev/999f09bf3464
So using 1.6 would only be a fairly temporary measure.
There are some (minor) differences in type inference between 1.7 and 1.8, so 1.7 is probably safer than 1.8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists