You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Spyros Kapnissis (Created) (JIRA)" <ji...@apache.org> on 2012/03/09 13:06:57 UTC
[jira] [Created] (SOLR-3226) SignatureUpdateProcessor ignores
non-string field values from the signature generation
SignatureUpdateProcessor ignores non-string field values from the signature generation
--------------------------------------------------------------------------------------
Key: SOLR-3226
URL: https://issues.apache.org/jira/browse/SOLR-3226
Project: Solr
Issue Type: Bug
Components: update
Affects Versions: 3.5, 4.0
Reporter: Spyros Kapnissis
When using for example XMLUpdateRequestProcessor, the signature is calculated correctly since all field values are strings. But when one uses DataImportHandler or BinaryUpdateRequestHandler, the signature generation will ignore any field values that are ints, longs, dates etc.
This might result in overwriting non-similar documents, as it happened in my case while importing some db data through DIH.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3226) SignatureUpdateProcessor ignores
non-string field values from the signature generation
Posted by "Hoss Man (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man resolved SOLR-3226.
----------------------------
Resolution: Fixed
Fix Version/s: 4.0
Committed revision 1308625. - 3x
> SignatureUpdateProcessor ignores non-string field values from the signature generation
> --------------------------------------------------------------------------------------
>
> Key: SOLR-3226
> URL: https://issues.apache.org/jira/browse/SOLR-3226
> Project: Solr
> Issue Type: Bug
> Components: update
> Affects Versions: 1.4, 3.1, 3.2, 3.3, 3.4, 3.5, 4.0
> Reporter: Spyros Kapnissis
> Assignee: Hoss Man
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3226.patch, SOLR-3226.patch
>
>
> When using for example XMLUpdateRequestProcessor, the signature is calculated correctly since all field values are strings. But when one uses DataImportHandler or BinaryUpdateRequestHandler, the signature generation will ignore any field values that are ints, longs, dates etc.
> This might result in overwriting non-similar documents, as it happened in my case while importing some db data through DIH.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3226) SignatureUpdateProcessor ignores
non-string field values from the signature generation
Posted by "Hoss Man (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-3226:
---------------------------
Attachment: SOLR-3226.patch
Hmmm .... just noticed this jira ... this definitely seems like a really bad bug.
Spyros: thank you so much for your patch (including tests!) ... i've updated it to also fix the case of Collections that contain non string.
> SignatureUpdateProcessor ignores non-string field values from the signature generation
> --------------------------------------------------------------------------------------
>
> Key: SOLR-3226
> URL: https://issues.apache.org/jira/browse/SOLR-3226
> Project: Solr
> Issue Type: Bug
> Components: update
> Affects Versions: 3.5, 4.0
> Reporter: Spyros Kapnissis
> Attachments: SOLR-3226.patch, SOLR-3226.patch
>
>
> When using for example XMLUpdateRequestProcessor, the signature is calculated correctly since all field values are strings. But when one uses DataImportHandler or BinaryUpdateRequestHandler, the signature generation will ignore any field values that are ints, longs, dates etc.
> This might result in overwriting non-similar documents, as it happened in my case while importing some db data through DIH.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3226) SignatureUpdateProcessor ignores
non-string field values from the signature generation
Posted by "Hoss Man (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-3226:
---------------------------
Affects Version/s: 1.4
3.1
3.2
3.3
3.4
Fix Version/s: 3.6
Assignee: Hoss Man
I wanna commit this into 3.6 ... but i'd like to get mark miller to sanity check th patch first (the instanceof String seems so deliberate i'm not sure if i'm missing something - i've pinged him on IRC to see if he can review ASAP)
Suggested special text for the upgrading section in CHANGES.txt...
{noformat}
A bug found and fixed in the SignatureUpdateProcessor that previously caused some
documents to produce the same signature even when the configured fields contained
distinct (non-String) values. Users of SignatureUpdateProcessor are strongly advised
that they should re-index as document signatures may have now changed.
(see SOLR-3226 for details)
{noformat}
> SignatureUpdateProcessor ignores non-string field values from the signature generation
> --------------------------------------------------------------------------------------
>
> Key: SOLR-3226
> URL: https://issues.apache.org/jira/browse/SOLR-3226
> Project: Solr
> Issue Type: Bug
> Components: update
> Affects Versions: 1.4, 3.1, 3.2, 3.3, 3.4, 3.5, 4.0
> Reporter: Spyros Kapnissis
> Assignee: Hoss Man
> Fix For: 3.6
>
> Attachments: SOLR-3226.patch, SOLR-3226.patch
>
>
> When using for example XMLUpdateRequestProcessor, the signature is calculated correctly since all field values are strings. But when one uses DataImportHandler or BinaryUpdateRequestHandler, the signature generation will ignore any field values that are ints, longs, dates etc.
> This might result in overwriting non-similar documents, as it happened in my case while importing some db data through DIH.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3226) SignatureUpdateProcessor ignores
non-string field values from the signature generation
Posted by "Hoss Man (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244799#comment-13244799 ]
Hoss Man commented on SOLR-3226:
--------------------------------
Committed revision 1308604. - trunk
...had to make a tweak to schema-luceneMatchVersion.xml to get all tests working however (TestMatchVersions uses same solrconfig.xml but diff schema.xml, so it freaked about "id" not existing)
still testing the backport to 3x ... there were some other subtle tweaks needed there to the test because of branch drift
> SignatureUpdateProcessor ignores non-string field values from the signature generation
> --------------------------------------------------------------------------------------
>
> Key: SOLR-3226
> URL: https://issues.apache.org/jira/browse/SOLR-3226
> Project: Solr
> Issue Type: Bug
> Components: update
> Affects Versions: 1.4, 3.1, 3.2, 3.3, 3.4, 3.5, 4.0
> Reporter: Spyros Kapnissis
> Assignee: Hoss Man
> Fix For: 3.6
>
> Attachments: SOLR-3226.patch, SOLR-3226.patch
>
>
> When using for example XMLUpdateRequestProcessor, the signature is calculated correctly since all field values are strings. But when one uses DataImportHandler or BinaryUpdateRequestHandler, the signature generation will ignore any field values that are ints, longs, dates etc.
> This might result in overwriting non-similar documents, as it happened in my case while importing some db data through DIH.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3226) SignatureUpdateProcessor ignores
non-string field values from the signature generation
Posted by "Spyros Kapnissis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Spyros Kapnissis updated SOLR-3226:
-----------------------------------
Attachment: SOLR-3226.patch
I'm adding a small patch that adds a simple String.valueOf for any field that fails the instanceof String typecheck.
> SignatureUpdateProcessor ignores non-string field values from the signature generation
> --------------------------------------------------------------------------------------
>
> Key: SOLR-3226
> URL: https://issues.apache.org/jira/browse/SOLR-3226
> Project: Solr
> Issue Type: Bug
> Components: update
> Affects Versions: 3.5, 4.0
> Reporter: Spyros Kapnissis
> Attachments: SOLR-3226.patch
>
>
> When using for example XMLUpdateRequestProcessor, the signature is calculated correctly since all field values are strings. But when one uses DataImportHandler or BinaryUpdateRequestHandler, the signature generation will ignore any field values that are ints, longs, dates etc.
> This might result in overwriting non-similar documents, as it happened in my case while importing some db data through DIH.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org