You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/09/28 13:46:09 UTC
[GitHub] [incubator-shenyu] tonytanCoder opened a new pull request #2166: The TestCase for ShenyuPluginLoader.
tonytanCoder opened a new pull request #2166:
URL: https://github.com/apache/incubator-shenyu/pull/2166
// Describe your PR here; eg. Fixes #issueNo
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #2166: The TestCase for ShenyuPluginLoader.
Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #2166:
URL: https://github.com/apache/incubator-shenyu/pull/2166#issuecomment-955902538
@tonytanCoder can you check ci？it not pass~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] tydhot commented on a change in pull request #2166: The TestCase for ShenyuPluginLoader.
Posted by GitBox <gi...@apache.org>.
tydhot commented on a change in pull request #2166:
URL: https://github.com/apache/incubator-shenyu/pull/2166#discussion_r720374771
##########
File path: shenyu-web/src/main/java/org/apache/shenyu/web/loader/ShenyuPluginLoader.java
##########
@@ -30,11 +30,7 @@
import java.io.IOException;
import java.net.MalformedURLException;
import java.net.URL;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.Enumeration;
-import java.util.List;
-import java.util.Objects;
+import java.util.*;
Review comment:
plz don't use * in imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #2166: The TestCase for ShenyuPluginLoader.
Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #2166:
URL: https://github.com/apache/incubator-shenyu/pull/2166#issuecomment-930707775
pls check ci。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] songyuequan commented on pull request #2166: The TestCase for ShenyuPluginLoader.
Posted by GitBox <gi...@apache.org>.
songyuequan commented on pull request #2166:
URL: https://github.com/apache/incubator-shenyu/pull/2166#issuecomment-974587173
hi @tonytanCoder please check ci.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] midnight2104 commented on pull request #2166: The TestCase for ShenyuPluginLoader.
Posted by GitBox <gi...@apache.org>.
midnight2104 commented on pull request #2166:
URL: https://github.com/apache/incubator-shenyu/pull/2166#issuecomment-963153755
hi @tonytanCoder please check ci.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] tonytanCoder commented on a change in pull request #2166: The TestCase for ShenyuPluginLoader.
Posted by GitBox <gi...@apache.org>.
tonytanCoder commented on a change in pull request #2166:
URL: https://github.com/apache/incubator-shenyu/pull/2166#discussion_r725413499
##########
File path: shenyu-web/src/main/java/org/apache/shenyu/web/loader/ShenyuPluginLoader.java
##########
@@ -30,11 +30,7 @@
import java.io.IOException;
import java.net.MalformedURLException;
import java.net.URL;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.Enumeration;
-import java.util.List;
-import java.util.Objects;
+import java.util.*;
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org