[GitHub] [kafka] ableegoldman commented on a change in pull request #11609: KAFKA-12648: fixes for query APIs and blocking calls

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r789559604



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java
##########
@@ -113,7 +113,7 @@ public StreamsMetadata getLocalMetadata() {
             return allMetadata;
         }
 
-        final Collection<String> sourceTopics = topologyMetadata.sourceTopicsForStore(storeName);
+        final Collection<String> sourceTopics = topologyMetadata.sourceTopicsForStore(storeName, null);

Review comment:
       Yes, the reason is that a single store name is not sufficient to identify the actual store with named topologies, since a name may be reused for different stores in different topologies. So a user must use the overload that also accepts a `topologyName` parameter.
   
   I will add a check that throws an informative exception if this method is called when named topologies are used, to be safe.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org