You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/25 13:06:07 UTC

[GitHub] [shardingsphere] totalo opened a new pull request #9824: add test cases for OrderedServicesCache

totalo opened a new pull request #9824:
URL: https://github.com/apache/shardingsphere/pull/9824


   Fixes #9789 
   
   Changes proposed in this pull request:
   - add test cases for OrderedServicesCache
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #9824: add test cases for OrderedServicesCache

Posted by GitBox <gi...@apache.org>.

terrymanu merged pull request #9824:
URL: https://github.com/apache/shardingsphere/pull/9824


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #9824: add test cases for OrderedServicesCache

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #9824:
URL: https://github.com/apache/shardingsphere/pull/9824#issuecomment-807905791


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/shardingsphere/pull/9824?src=pr&el=desc) (6ddf4b7) into [master](https://codecov.io/gh/apache/shardingsphere/commit/2f3a4d28a64b36de3577163b22eaa63cc2ee8199?el=desc) (2f3a4d2) will **decrease** coverage by `0.17%`.
   > The diff coverage is `23.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9824      +/-   ##
   ============================================
   - Coverage     67.87%   67.70%   -0.18%     
   + Complexity      678      676       -2     
   ============================================
     Files          1670     1669       -1     
     Lines         27893    27919      +26     
     Branches       4934     4943       +9     
   ============================================
   - Hits          18932    18902      -30     
   - Misses         7566     7621      +55     
   - Partials       1395     1396       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9824?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...tebuddy/transformer/ShardingSphereTransformer.java](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9ieXRlYnVkZHkvdHJhbnNmb3JtZXIvU2hhcmRpbmdTcGhlcmVUcmFuc2Zvcm1lci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/advice/ComposeClassStaticMethodAroundAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9ieXRlYnVkZHkvdHJhbnNmb3JtZXIvYWR2aWNlL0NvbXBvc2VDbGFzc1N0YXRpY01ldGhvZEFyb3VuZEFkdmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...y/transformer/advice/ComposeConstructorAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9ieXRlYnVkZHkvdHJhbnNmb3JtZXIvYWR2aWNlL0NvbXBvc2VDb25zdHJ1Y3RvckFkdmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...rmer/advice/ComposeInstanceMethodAroundAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9ieXRlYnVkZHkvdHJhbnNmb3JtZXIvYWR2aWNlL0NvbXBvc2VJbnN0YW5jZU1ldGhvZEFyb3VuZEFkdmljZS5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
   | [...ose/ComposeClassStaticMethodAroundInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vaW50ZXJjZXB0b3IvY29tcG9zZS9Db21wb3NlQ2xhc3NTdGF0aWNNZXRob2RBcm91bmRJbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...rceptor/compose/ComposeConstructorInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vaW50ZXJjZXB0b3IvY29tcG9zZS9Db21wb3NlQ29uc3RydWN0b3JJbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ompose/ComposeInstanceMethodAroundInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vaW50ZXJjZXB0b3IvY29tcG9zZS9Db21wb3NlSW5zdGFuY2VNZXRob2RBcm91bmRJbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...prometheus/register/PrometheusMetricsRegister.java](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tbWV0cmljcy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvcHJvbWV0aGV1cy9yZWdpc3Rlci9Qcm9tZXRoZXVzTWV0cmljc1JlZ2lzdGVyLmphdmE=) | `94.00% <ø> (-0.12%)` | `1.00 <0.00> (ø)` | |
   | [...ket/command/query/PostgreSQLColumnDescription.java](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9Qb3N0Z3JlU1FMQ29sdW1uRGVzY3JpcHRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...y/common/rule/DatabaseDiscoveryDataSourceRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL2Rpc2NvdmVyeS9jb21tb24vcnVsZS9EYXRhYmFzZURpc2NvdmVyeURhdGFTb3VyY2VSdWxlLmphdmE=) | `95.45% <ø> (-0.20%)` | `0.00 <0.00> (ø)` | |
   | ... and [17 more](https://codecov.io/gh/apache/shardingsphere/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9824?src=pr&el=footer). Last update [5c896a4...6ddf4b7](https://codecov.io/gh/apache/shardingsphere/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org