You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/27 19:40:29 UTC
[GitHub] [airflow] kaxil opened a new pull request #13932: Pass Flag to not load operator links for Scheduler
kaxil opened a new pull request #13932:
URL: https://github.com/apache/airflow/pull/13932
closes #13099
Mutually exclusive with https://github.com/apache/airflow/pull/13931
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #13932: Pass Flag to not load operator links for Scheduler
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #13932:
URL: https://github.com/apache/airflow/pull/13932#issuecomment-768532001
https://github.com/apache/airflow/pull/13931 is an alternative approach however we manage some sort of global state -- but we remove the env var before we exiting `_do_scheduling`
~~cc @ashb -- I will add tests once we decide on the approach~~ Test added in https://github.com/apache/airflow/pull/13932/commits/1ee706ce312dabf010a2b241d018847ba714c188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13932: Stop loading Extra Operator links in Scheduler
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13932:
URL: https://github.com/apache/airflow/pull/13932#issuecomment-770275265
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13932: Pass Flag to not load operator links for Scheduler
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13932:
URL: https://github.com/apache/airflow/pull/13932#issuecomment-768601834
[The Workflow run](https://github.com/apache/airflow/actions/runs/516247430) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13932: Pass Flag to not load operator links for Scheduler
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13932:
URL: https://github.com/apache/airflow/pull/13932#issuecomment-768532001
This works but feels ugly and prone to error — i.e if someone adds another `self.dagbag.get `somewhere and misses the `load_op_links` flag — then op link will be loaded again.
https://github.com/apache/airflow/pull/13931 looks much cleaner in my opinion -- however we manage some sort of global state -- but we remove the env var before we exist `_do_scheduling`
cc @ashb -- I will add tests once we decide on the approach
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13932: Pass Flag to not load operator links for Scheduler
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13932:
URL: https://github.com/apache/airflow/pull/13932#issuecomment-770047667
> I prefer this approach to the global state of environment variables. Is it necessary to pass `load_op_links` to DagBag's constructor though?
>
> I'm not super familiar with the how this is used, so it might not make sense, but could it be passed directly to `deserialize_operator` as an argument?
Mainly to reduce the places we need to pass the flag otherwise -- https://github.com/apache/airflow/pull/13932/commits/dab163e80bb62d7d8fb43b4adb7654c5b6c3e3ba is my first commit where I tried something similar but its too ugly -- I passed it all the over the place
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13932: Pass Flag to not load operator links for Scheduler
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13932:
URL: https://github.com/apache/airflow/pull/13932#issuecomment-769156036
@ephraimbuddy @jhtimmins Can you take a look and review too please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #13932: Pass Flag to not load operator links for Scheduler
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #13932:
URL: https://github.com/apache/airflow/pull/13932#issuecomment-768532001
https://github.com/apache/airflow/pull/13931 is an alternative approach however we manage some sort of global state -- but we remove the env var before we exiting `_do_scheduling`
cc @ashb -- I will add tests once we decide on the approach
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13932: Pass Flag to not load operator links for Scheduler
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13932:
URL: https://github.com/apache/airflow/pull/13932#issuecomment-768677881
[The Workflow run](https://github.com/apache/airflow/actions/runs/516634566) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13932: Stop loading Extra Operator links in Scheduler
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13932:
URL: https://github.com/apache/airflow/pull/13932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org