You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by zi...@apache.org on 2025/07/03 01:58:47 UTC
(pulsar) branch master updated: [fix][client] NPE in MultiTopicsConsumerImpl.negativeAcknowledge (#24476)
This is an automated email from the ASF dual-hosted git repository.
zixuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 89167308709 [fix][client] NPE in MultiTopicsConsumerImpl.negativeAcknowledge (#24476)
89167308709 is described below
commit 89167308709cf72d3f2731bad1bb30384f80abb4
Author: Penghui Li <pe...@apache.org>
AuthorDate: Wed Jul 2 18:58:39 2025 -0700
[fix][client] NPE in MultiTopicsConsumerImpl.negativeAcknowledge (#24476)
---
.../org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
index 04dfe5cc950..727a71a9b8d 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
@@ -571,6 +571,11 @@ public class MultiTopicsConsumerImpl<T> extends ConsumerBase<T> {
@Override
public void negativeAcknowledge(MessageId messageId) {
+ if (getState() != State.Ready) {
+ log.warn("[{}] [{}] Cannot negative acknowledge message {} - consumer is not ready (state: {})",
+ topic, subscription, messageId, getState());
+ return;
+ }
checkArgument(messageId instanceof TopicMessageId);
ConsumerImpl<T> consumer = consumers.get(((TopicMessageId) messageId).getOwnerTopic());
consumer.negativeAcknowledge(messageId);
@@ -579,6 +584,11 @@ public class MultiTopicsConsumerImpl<T> extends ConsumerBase<T> {
@Override
public void negativeAcknowledge(Message<?> message) {
+ if (getState() != State.Ready) {
+ log.warn("[{}] [{}] Cannot negative acknowledge message {} - consumer is not ready (state: {})",
+ topic, subscription, message.getMessageId(), getState());
+ return;
+ }
MessageId messageId = message.getMessageId();
checkArgument(messageId instanceof TopicMessageId);
ConsumerImpl<T> consumer = consumers.get(((TopicMessageId) messageId).getOwnerTopic());