[GitHub] [spark] panbingkun commented on a diff in pull request #38555: [WIP][SPARK-41044][SQL] Convert DATATYPE_MISMATCH.UNSPECIFIED_FRAME to DATATYPE_MISMATCH.INTERNAL_ERROR

[GitBox <gi...@apache.org>]

panbingkun commented on code in PR #38555:
URL: https://github.com/apache/spark/pull/38555#discussion_r1016344333


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala:
##########
@@ -66,7 +66,13 @@ case class WindowSpecDefinition(
   override def checkInputDataTypes(): TypeCheckResult = {
     frameSpecification match {
       case UnspecifiedFrame =>
-        DataTypeMismatch(errorSubClass = "UNSPECIFIED_FRAME")
+        DataTypeMismatch(
+          errorSubClass = "INTERNAL_ERROR",
+          messageParameters = Map(
+            "message" -> ("Cannot use an UnspecifiedFrame. " +
+              "This should have been converted during analysis.")

Review Comment:
   cannot throw an exception here, otherwise cannot continue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org