You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/13 09:03:09 UTC
[GitHub] [flink] hameizi opened a new pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
hameizi opened a new pull request #16806:
URL: https://github.com/apache/flink/pull/16806
…ic properties file
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
As discusstion in https://issues.apache.org/jira/browse/FLINK-15470, the config in YARN magic properties file will effect our yarn config in flink sql/jar job when we first start on yarn app by "./bin/yarn-session.sh". So we need cover the config of magic file by user's config.
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hameizi commented on a change in pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
hameizi commented on a change in pull request #16806:
URL: https://github.com/apache/flink/pull/16806#discussion_r693922621
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -81,6 +91,57 @@ private YarnClusterDescriptor getClusterDescriptor(Configuration configuration)
yarnClient.init(yarnConfiguration);
yarnClient.start();
+ if (configuration.contains(YarnConfigOptions.APPLICATION_NAME)) {
+ try {
+ Set<String> applicationTypes = Sets.newHashSet();
+ applicationTypes.add("Apache Flink");
Review comment:
Yes, it's a wrong code, i will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16806:
URL: https://github.com/apache/flink/pull/16806#issuecomment-898327297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4012790bb7b8059ad736ab24394266817d2f3137",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4012790bb7b8059ad736ab24394266817d2f3137",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4012790bb7b8059ad736ab24394266817d2f3137 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16806:
URL: https://github.com/apache/flink/pull/16806#issuecomment-898327297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4012790bb7b8059ad736ab24394266817d2f3137",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22077",
"triggerID" : "4012790bb7b8059ad736ab24394266817d2f3137",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4012790bb7b8059ad736ab24394266817d2f3137 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22077)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hameizi closed pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
hameizi closed pull request #16806:
URL: https://github.com/apache/flink/pull/16806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16806:
URL: https://github.com/apache/flink/pull/16806#issuecomment-898305671
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4012790bb7b8059ad736ab24394266817d2f3137 (Fri Aug 13 09:08:00 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-23763).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hameizi commented on pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
hameizi commented on pull request #16806:
URL: https://github.com/apache/flink/pull/16806#issuecomment-903740993
> Do you want to make Flink applications discoverable via an application name? Isn't it enough to specify the `APPLICATION_ID`? Does Yarn guarantee that there can only be a single application with a given name?
Yes, i want to make Flink applications discoverable via an application name, because the `APPLICATION_ID` is dynamic and not easy to determine, but application name is certain for user. Yarn can't guarantee that there can only be a single application with a given name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #16806:
URL: https://github.com/apache/flink/pull/16806#issuecomment-903810766
But what if there are multiple Yarn applications with the same name? What should be the expected behaviour in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16806:
URL: https://github.com/apache/flink/pull/16806#issuecomment-898327297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4012790bb7b8059ad736ab24394266817d2f3137",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22077",
"triggerID" : "4012790bb7b8059ad736ab24394266817d2f3137",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4012790bb7b8059ad736ab24394266817d2f3137 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22077)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16806:
URL: https://github.com/apache/flink/pull/16806#issuecomment-898327297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4012790bb7b8059ad736ab24394266817d2f3137",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22077",
"triggerID" : "4012790bb7b8059ad736ab24394266817d2f3137",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4012790bb7b8059ad736ab24394266817d2f3137 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22077)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hameizi removed a comment on pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
hameizi removed a comment on pull request #16806:
URL: https://github.com/apache/flink/pull/16806#issuecomment-903736640
> Thanks for creating this PR @hameizi. I am not 100% whether I fully understand the change. Do you want to make Flink applications discoverable via an application name? Isn't it enough to specify the `APPLICATION_ID`? Does Yarn guarantee that there can only be a single application with a given name?
>
> Besides this general question, I think this PR lacks a bit of test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #16806:
URL: https://github.com/apache/flink/pull/16806#discussion_r692154118
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -81,6 +91,57 @@ private YarnClusterDescriptor getClusterDescriptor(Configuration configuration)
yarnClient.init(yarnConfiguration);
yarnClient.start();
+ if (configuration.contains(YarnConfigOptions.APPLICATION_NAME)) {
+ try {
+ Set<String> applicationTypes = Sets.newHashSet();
+ applicationTypes.add("Apache Flink");
Review comment:
I think the application type can be something different than `"Apache Flink"`. See `YarnConfigOptions.APPLICATION_TYPE`.
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -81,6 +91,57 @@ private YarnClusterDescriptor getClusterDescriptor(Configuration configuration)
yarnClient.init(yarnConfiguration);
yarnClient.start();
+ if (configuration.contains(YarnConfigOptions.APPLICATION_NAME)) {
+ try {
+ Set<String> applicationTypes = Sets.newHashSet();
+ applicationTypes.add("Apache Flink");
+ EnumSet<YarnApplicationState> applicationStates =
+ EnumSet.noneOf(YarnApplicationState.class);
+ applicationStates.add(YarnApplicationState.RUNNING);
+ List<ApplicationReport> applicationReports =
+ yarnClient.getApplications(applicationTypes, applicationStates);
+ Collections.sort(
+ applicationReports,
+ (o1, o2) -> {
+ long o1Time = o1.getApplicationId().getClusterTimestamp();
+ long o2Time = o2.getApplicationId().getClusterTimestamp();
+ long o1Id = o1.getApplicationId().getId();
+ long o2Id = o2.getApplicationId().getId();
+ if (o1Time > o2Time) {
+ return -1;
+ } else if (o1Time == o2Time) {
+ return (o1Id < o2Id) ? 1 : -1;
+ } else {
+ return 1;
+ }
+ });
+ if (CollectionUtils.isNotEmpty(applicationReports)) {
+ for (ApplicationReport applicationReport : applicationReports) {
+ if (StringUtils.equals(
+ applicationReport.getName(),
+ configuration.get(YarnConfigOptions.APPLICATION_NAME))) {
+ if (configuration.contains(YarnConfigOptions.APPLICATION_QUEUE)) {
+ if (StringUtils.equals(
+ applicationReport.getQueue(),
+ configuration.get(YarnConfigOptions.APPLICATION_QUEUE))) {
+ configuration.setString(
+ YarnConfigOptions.APPLICATION_ID,
+ applicationReport.getApplicationId().toString());
+ break;
+ }
+ } else {
+ configuration.setString(
+ YarnConfigOptions.APPLICATION_ID,
+ applicationReport.getApplicationId().toString());
+ break;
+ }
+ }
+ }
+ }
+ } catch (Exception e) {
+ e.printStackTrace();
+ }
Review comment:
In case of a failure, we should propagate the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hameizi commented on pull request #16806: [FLINK-23763][Deployment/YARN]Use yarn config in sql but not yarn mag…
Posted by GitBox <gi...@apache.org>.
hameizi commented on pull request #16806:
URL: https://github.com/apache/flink/pull/16806#issuecomment-903736640
> Thanks for creating this PR @hameizi. I am not 100% whether I fully understand the change. Do you want to make Flink applications discoverable via an application name? Isn't it enough to specify the `APPLICATION_ID`? Does Yarn guarantee that there can only be a single application with a given name?
>
> Besides this general question, I think this PR lacks a bit of test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org