You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/20 03:15:06 UTC
[GitHub] [flink] JingsongLi opened a new pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
JingsongLi opened a new pull request #13694:
URL: https://github.com/apache/flink/pull/13694
## What is the purpose of the change
Introduce new Providers and parallelism API
PR for All Public API.
## Brief change log
- Introduce SourceProvider
- Introduce DataStreamSourceProvider
- Introduce DataStreamSinkProvider
- Introduce ParallelismProvider
- Introduce SINK_PARALLELISM option
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712569945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c92d927517014392d271509620f48ad81a1ffc5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897",
"triggerID" : "c92d927517014392d271509620f48ad81a1ffc5e",
"triggerType" : "PUSH"
}, {
"hash" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7906",
"triggerID" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"triggerType" : "PUSH"
}, {
"hash" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7916",
"triggerID" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"triggerType" : "PUSH"
}, {
"hash" : "f31b6312ad11aa10b773528bda15c0ca9460c0d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f31b6312ad11aa10b773528bda15c0ca9460c0d4",
"triggerType" : "PUSH"
}, {
"hash" : "8274ea7a5b5e122844b2635aab700f1f9d6d1a09",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8167",
"triggerID" : "8274ea7a5b5e122844b2635aab700f1f9d6d1a09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32dd70d47f901c7ce393852a890518b06bbb236b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7916)
* f31b6312ad11aa10b773528bda15c0ca9460c0d4 UNKNOWN
* 8274ea7a5b5e122844b2635aab700f1f9d6d1a09 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8167)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13694:
URL: https://github.com/apache/flink/pull/13694#discussion_r510768230
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/connector/sink/DataStreamSinkProvider.java
##########
@@ -24,16 +24,16 @@
import org.apache.flink.table.data.RowData;
/**
- * Provider to consume a {@link DataStream} as a runtime implementation for
- * {@link DynamicTableSink}.
+ * Provider that consumes a Java {@link DataStream} as a runtime implementation for {@link DynamicTableSink}.
*
- * <p>NOTE: This is only for advanced connector developers.
+ * <p>Note: This provider is only meant for advanced connector developers. Usually, a sink should consist
+ * of a single entity expressed via {@link OutputFormatProvider} or {@link SinkFunctionProvider}.
Review comment:
+1 for this. This makes the responsibility of this interface more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-715283580
Thanks @wuchong @godfreyhe @twalthr for your review, I'll merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712569945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c92d927517014392d271509620f48ad81a1ffc5e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897",
"triggerID" : "c92d927517014392d271509620f48ad81a1ffc5e",
"triggerType" : "PUSH"
}, {
"hash" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c92d927517014392d271509620f48ad81a1ffc5e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897)
* b27370c0eb53a5f4b0799763b57bd73f79b1e386 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712561874
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c92d927517014392d271509620f48ad81a1ffc5e (Tue Oct 20 03:17:03 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712569945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c92d927517014392d271509620f48ad81a1ffc5e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897",
"triggerID" : "c92d927517014392d271509620f48ad81a1ffc5e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c92d927517014392d271509620f48ad81a1ffc5e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #13694:
URL: https://github.com/apache/flink/pull/13694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712569945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c92d927517014392d271509620f48ad81a1ffc5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897",
"triggerID" : "c92d927517014392d271509620f48ad81a1ffc5e",
"triggerType" : "PUSH"
}, {
"hash" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7906",
"triggerID" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"triggerType" : "PUSH"
}, {
"hash" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b27370c0eb53a5f4b0799763b57bd73f79b1e386 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7906)
* 32dd70d47f901c7ce393852a890518b06bbb236b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712569945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c92d927517014392d271509620f48ad81a1ffc5e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c92d927517014392d271509620f48ad81a1ffc5e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c92d927517014392d271509620f48ad81a1ffc5e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712569945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c92d927517014392d271509620f48ad81a1ffc5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897",
"triggerID" : "c92d927517014392d271509620f48ad81a1ffc5e",
"triggerType" : "PUSH"
}, {
"hash" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7906",
"triggerID" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"triggerType" : "PUSH"
}, {
"hash" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7916",
"triggerID" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32dd70d47f901c7ce393852a890518b06bbb236b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7916)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712569945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c92d927517014392d271509620f48ad81a1ffc5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897",
"triggerID" : "c92d927517014392d271509620f48ad81a1ffc5e",
"triggerType" : "PUSH"
}, {
"hash" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7906",
"triggerID" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"triggerType" : "PUSH"
}, {
"hash" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7916",
"triggerID" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"triggerType" : "PUSH"
}, {
"hash" : "f31b6312ad11aa10b773528bda15c0ca9460c0d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f31b6312ad11aa10b773528bda15c0ca9460c0d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32dd70d47f901c7ce393852a890518b06bbb236b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7916)
* f31b6312ad11aa10b773528bda15c0ca9460c0d4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712569945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c92d927517014392d271509620f48ad81a1ffc5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897",
"triggerID" : "c92d927517014392d271509620f48ad81a1ffc5e",
"triggerType" : "PUSH"
}, {
"hash" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7906",
"triggerID" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"triggerType" : "PUSH"
}, {
"hash" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7916",
"triggerID" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b27370c0eb53a5f4b0799763b57bd73f79b1e386 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7906)
* 32dd70d47f901c7ce393852a890518b06bbb236b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7916)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13694:
URL: https://github.com/apache/flink/pull/13694#discussion_r508193816
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java
##########
@@ -73,6 +73,12 @@
"Uniquely identifies the connector of a dynamic table that is used for accessing data in " +
"an external system. Its value is used during table source and table sink discovery.");
+ public static final ConfigOption<Integer> SINK_PARALLELISM = ConfigOptions
+ .key("sink.parallelism")
+ .intType()
+ .noDefaultValue()
+ .withDescription("Defines the user specified sink parallelism.");
Review comment:
"Defines the user specified parallelism for the sink." ?
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/ParallelismProvider.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.util.Optional;
+
+/**
+ * Parallelism provider for connector providers.
+ * Now only works on {@code SinkFunctionProvider} and {@code OutputFormatProvider}.
Review comment:
```suggestion
*
* <p>Note: currently, it only supports to work with {@code SinkFunctionProvider} and {@code OutputFormatProvider}.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712569945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c92d927517014392d271509620f48ad81a1ffc5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897",
"triggerID" : "c92d927517014392d271509620f48ad81a1ffc5e",
"triggerType" : "PUSH"
}, {
"hash" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7906",
"triggerID" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b27370c0eb53a5f4b0799763b57bd73f79b1e386 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7906)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13694:
URL: https://github.com/apache/flink/pull/13694#discussion_r510768230
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/connector/sink/DataStreamSinkProvider.java
##########
@@ -24,16 +24,16 @@
import org.apache.flink.table.data.RowData;
/**
- * Provider to consume a {@link DataStream} as a runtime implementation for
- * {@link DynamicTableSink}.
+ * Provider that consumes a Java {@link DataStream} as a runtime implementation for {@link DynamicTableSink}.
*
- * <p>NOTE: This is only for advanced connector developers.
+ * <p>Note: This provider is only meant for advanced connector developers. Usually, a sink should consist
+ * of a single entity expressed via {@link OutputFormatProvider} or {@link SinkFunctionProvider}.
Review comment:
+1 for this. This makes the responsity of this interface more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-712569945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c92d927517014392d271509620f48ad81a1ffc5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7897",
"triggerID" : "c92d927517014392d271509620f48ad81a1ffc5e",
"triggerType" : "PUSH"
}, {
"hash" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7906",
"triggerID" : "b27370c0eb53a5f4b0799763b57bd73f79b1e386",
"triggerType" : "PUSH"
}, {
"hash" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7916",
"triggerID" : "32dd70d47f901c7ce393852a890518b06bbb236b",
"triggerType" : "PUSH"
}, {
"hash" : "f31b6312ad11aa10b773528bda15c0ca9460c0d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f31b6312ad11aa10b773528bda15c0ca9460c0d4",
"triggerType" : "PUSH"
}, {
"hash" : "8274ea7a5b5e122844b2635aab700f1f9d6d1a09",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8274ea7a5b5e122844b2635aab700f1f9d6d1a09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32dd70d47f901c7ce393852a890518b06bbb236b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7916)
* f31b6312ad11aa10b773528bda15c0ca9460c0d4 UNKNOWN
* 8274ea7a5b5e122844b2635aab700f1f9d6d1a09 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-714290557
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #13694:
URL: https://github.com/apache/flink/pull/13694#issuecomment-715197041
Thanks for working on this issue @JingsongLi. I pushed a commit with a couple of suggestions. Feel free to undo whatever you don't like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org