You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "duke8253 (via GitHub)" <gi...@apache.org> on 2024/05/13 20:06:38 UTC

[PR] Handle EOS events during server open [trafficserver]

duke8253 opened a new pull request, #11346:
URL: https://github.com/apache/trafficserver/pull/11346

   We saw a bunch of aborts happening due to EOS not being handled during `HttpSM::state_http_server_open`, and after some discussion we believe this should be handled the same as a `VC_EVENT_ERROR` case. This is now deployed globally for us. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Handle EOS events during server open [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11346:
URL: https://github.com/apache/trafficserver/pull/11346#issuecomment-2112949224

   Other places with `VC_EVENT_ERROR` but not `VC_EVENT_EOS`
   
   ```
   src/iocore/net/QUICNextProtocolAccept.cc|44 col 8| case VC_EVENT_ERROR:
   src/proxy/http/HttpSM.cc|1232 col 8| case VC_EVENT_ERROR:
   src/proxy/http/HttpSM.cc|1808 col 8| case VC_EVENT_ERROR:
   src/proxy/Transform.cc|634 col 10| case VC_EVENT_ERROR:
   src/proxy/Transform.cc|793 col 10| case VC_EVENT_ERROR:
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Handle EOS events during server open [trafficserver]

Posted by "duke8253 (via GitHub)" <gi...@apache.org>.
duke8253 merged PR #11346:
URL: https://github.com/apache/trafficserver/pull/11346


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Handle EOS events during server open [trafficserver]

Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on PR #11346:
URL: https://github.com/apache/trafficserver/pull/11346#issuecomment-2596468124

   Do we still want this for 9.2?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Handle EOS events during server open [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11346:
URL: https://github.com/apache/trafficserver/pull/11346#issuecomment-2129765406

   Cherry-picked to v10.0.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org