[GitHub] [yetus] saintstack commented on a change in pull request #86: YETUS-934. Precommit does not accept a caller's value of MAVEN_ARGS

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #86: YETUS-934. Precommit does not accept a caller's value of MAVEN_ARGS
URL: https://github.com/apache/yetus/pull/86#discussion_r376066133
 
 

 ##########
 File path: precommit/src/main/shell/test-patch.d/maven.sh
 ##########
 @@ -14,7 +14,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-declare -a MAVEN_ARGS
+# Accept a value of MAVEN_ARGS from the calling context
+# shellcheck disable=SC2206
 
 Review comment:
   This is what I pushed last night into hbase-personality... it don't work either.
   
   -  export MAVEN_ARGS="-T0.5C ${MAVEN_ARGS}"
   +  MAVEN_ARGS=("-T0.5C" "${MAVEN_ARGS[@]}")
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services