You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/12 06:16:53 UTC
[GitHub] [shardingsphere] linghengqian opened a new issue, #20935: The JDK minimum compiled version of the ShardingSphere project bump the timeline of JDK11
linghengqian opened a new issue, #20935:
URL: https://github.com/apache/shardingsphere/issues/20935
## Feature Request
**For English only**, other languages will not accept.
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Is your feature request related to a problem?
- Yes, refer to https://github.com/apache/shardingsphere/pull/20008 and https://github.com/apache/shardingsphere/pull/20119 .
### Describe the feature you would like.
- Starting from Antlr 4.10, it requires users to have a minimum JDK version of 11. Refer to https://github.com/antlr/antlr4/releases/tag/4.10.1 .
- And for Hibernate which relies on Antlr, it uses Antlr 4.10 from 6.0.1, Hibernate `6.x` works on SpringBoot OSS `3.x`, for ShardingSphere JDBC `5.2.0` which uses Antlr `4.9`, this breaks ShardingSphere JDBC Use of hybrid deployment form with zookeeper/etcd.
- I think it's time to consider the point in time when the minimum compiled version of ShardingSphere is raised to JDK11. I think this event should appear later than November 2022, when SpringBoot OSS `3.0.0` releases the first Release version. For the master branch of ShardingSphere, in which version should it raise the minimum build version? Is it ShardingSphere `5.3.0` or ShardingSphere `6.0.0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1378532186
- @zhfeng The official voting procedure should be transferred to the maillist, this issue should not be responsible for any related voting from the process, and I am not a Committer.
- The reason I didn't turn on the maillist was simply because it wasn't my need, which was @shanrenxj's need in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhfeng commented on issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1378616747
@linghengqian I'm not a Committer either. But it is free to ask a voting on the community, the PMC has a binding `+1` and anyone can show his/her opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhfeng commented on issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1380435514
Hi @shanrenxj,
We are not pushing people but trying to figure it out. Currently I'm working with @linghengqian to resolve the `antlr4` upgrading issue by not breaking the `JDK 8` support.
The most thing is like
- We need to change to build `shardingsphere ` with JDK > 11 only.
- But it is still compatitable with JDK 1.8 which the people should be good at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] shanrenxj commented on issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by GitBox <gi...@apache.org>.
shanrenxj commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1380406025
It's time to give those programmers who refuse to embrace new things a head start. Let them stay in the old shardingsphere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhfeng commented on issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1378671142
Hi @terrymanu @linghengqian @TeslaCN @taojintianxia @shanrenxj,
I raise a thread [Plan to drop JDK 8](https://lists.apache.org/thread/kgtfx5vnw73o61lkvdshyfvjfvvzk3js) on the mailing list, and please review and discuss there. I'm open to any idea.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1380451772
- I'm afraid I haven't had the energy to explore the corresponding PR for https://github.com/antlr/antlr4/issues/2448 . The release cycle of Antlr4 seems to be extremely long, and I'm not sure how to deal with something like `antlr.skip` in the end. I've recently been exploring Runtime Reflection issues surrounding GraalVM with byte-buddy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhfeng commented on issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1380479155
No, it should be OK without this skip propery with antlr4. I'm trying to prepare a PR to `force build shardingsphere with JDK 11`. @linghengqian please go head with your current works on GraalVM. I'm looking forward the `shardingsphere-native-proxy` which will be awsome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian closed issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian closed issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
URL: https://github.com/apache/shardingsphere/issues/20935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #20935: The JDK minimum compiled version of the ShardingSphere project bump the timeline of JDK11
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1272348476
Hello , this issue has not received a reply for several days.
This issue is supposed to be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #20935: The JDK minimum compiled version of the ShardingSphere project bump the timeline of JDK11
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1272356408
- I'm reopening this issue because no one has responded to the time point, and I'll submit a PR directly if it's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhfeng commented on issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1378527641
Vote on github issue? Is it an official process? I think it should happen on the mailing list although it seems few peope take care of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhfeng commented on issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1382028703
Please review https://github.com/apache/shardingsphere/pull/23550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #20935: Discuss the time to increase the minimum JDK compilation version of the ShardingSphere project to 11
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1407681982
- Resolved by https://github.com/apache/shardingsphere/pull/23550. Antlr4 has nothing to do with this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on issue #20935: The JDK minimum compiled version of the ShardingSphere project bump the timeline of JDK11
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1273994076
> * I'm reopening this issue because no one has responded to the time point, and I'll submit a PR directly if it's ok.
This may impact a lot of users. It's better to discuss breaking changes in mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #20935: The JDK minimum compiled version of the ShardingSphere project bump the timeline of JDK11
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #20935:
URL: https://github.com/apache/shardingsphere/issues/20935#issuecomment-1274001733
- Considering the process at https://github.com/apache/shardingsphere/issues/1157, maybe it would be better for PMC to start a new email thread? 👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] closed issue #20935: The JDK minimum compiled version of the ShardingSphere project bump the timeline of JDK11
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #20935: The JDK minimum compiled version of the ShardingSphere project bump the timeline of JDK11
URL: https://github.com/apache/shardingsphere/issues/20935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org