You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/05/21 01:19:47 UTC
[GitHub] [incubator-doris] hf200012 opened a new pull request #5866: [Features]Add mysql last_day function support
hf200012 opened a new pull request #5866:
URL: https://github.com/apache/incubator-doris/pull/5866
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5866: [Features]Add mysql last_day function support
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #5866:
URL: https://github.com/apache/incubator-doris/pull/5866#discussion_r642187423
##########
File path: be/src/exprs/timestamp_functions.cpp
##########
@@ -608,6 +608,28 @@ DateTimeVal TimestampFunctions::time_round(FunctionContext* ctx, const DateTimeV
return new_ts_val;
}
+DateTimeVal TimestampFunctions::last_day(FunctionContext* ctx, const DateTimeVal& ts_val) {
+ if (ts_val.is_null) {
+ return DateTimeVal::null();
+ }
+ const DateTimeValue& ts_value = DateTimeValue::from_datetime_val(ts_val);
+ int last_days[12] = {31,28,31,30,31,30,31,31,30,31,30,31};
+ int day ;
+ int year = ts_value.year();
+ int month = ts_value.month();
+ if((year % 4 == 0 && year % 100 !=0)||(year % 400 ==0 )) {
Review comment:
Additional white space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on pull request #5866: [Features]Add mysql last_day function support
Posted by GitBox <gi...@apache.org>.
hf200012 commented on pull request #5866:
URL: https://github.com/apache/incubator-doris/pull/5866#issuecomment-850808513
> You need to add ut for this function, on BE side.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on a change in pull request #5866: [Features]Add mysql last_day function support
Posted by GitBox <gi...@apache.org>.
hf200012 commented on a change in pull request #5866:
URL: https://github.com/apache/incubator-doris/pull/5866#discussion_r642301079
##########
File path: be/src/exprs/timestamp_functions.cpp
##########
@@ -608,6 +608,28 @@ DateTimeVal TimestampFunctions::time_round(FunctionContext* ctx, const DateTimeV
return new_ts_val;
}
+DateTimeVal TimestampFunctions::last_day(FunctionContext* ctx, const DateTimeVal& ts_val) {
+ if (ts_val.is_null) {
+ return DateTimeVal::null();
+ }
+ const DateTimeValue& ts_value = DateTimeValue::from_datetime_val(ts_val);
+ int last_days[12] = {31,28,31,30,31,30,31,31,30,31,30,31};
+ int day ;
+ int year = ts_value.year();
+ int month = ts_value.month();
+ if((year % 4 == 0 && year % 100 !=0)||(year % 400 ==0 )) {
Review comment:
solved
##########
File path: be/src/exprs/timestamp_functions.cpp
##########
@@ -608,6 +608,28 @@ DateTimeVal TimestampFunctions::time_round(FunctionContext* ctx, const DateTimeV
return new_ts_val;
}
+DateTimeVal TimestampFunctions::last_day(FunctionContext* ctx, const DateTimeVal& ts_val) {
+ if (ts_val.is_null) {
+ return DateTimeVal::null();
+ }
+ const DateTimeValue& ts_value = DateTimeValue::from_datetime_val(ts_val);
+ int last_days[12] = {31,28,31,30,31,30,31,31,30,31,30,31};
+ int day ;
+ int year = ts_value.year();
+ int month = ts_value.month();
+ if((year % 4 == 0 && year % 100 !=0)||(year % 400 ==0 )) {
+ day = 29 ;
+ } else {
+ day = last_days[month - 1];
Review comment:
solved
##########
File path: be/src/exprs/timestamp_functions.cpp
##########
@@ -608,6 +608,28 @@ DateTimeVal TimestampFunctions::time_round(FunctionContext* ctx, const DateTimeV
return new_ts_val;
}
+DateTimeVal TimestampFunctions::last_day(FunctionContext* ctx, const DateTimeVal& ts_val) {
+ if (ts_val.is_null) {
+ return DateTimeVal::null();
+ }
+ const DateTimeValue& ts_value = DateTimeValue::from_datetime_val(ts_val);
+ int last_days[12] = {31,28,31,30,31,30,31,31,30,31,30,31};
Review comment:
solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #5866: [Features]Add mysql last_day function support
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #5866:
URL: https://github.com/apache/incubator-doris/pull/5866#issuecomment-851893852
It’s better to link an issue for new features ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #5866: [Features]Add mysql last_day function support
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #5866:
URL: https://github.com/apache/incubator-doris/pull/5866#discussion_r641916477
##########
File path: be/src/exprs/timestamp_functions.cpp
##########
@@ -608,6 +608,28 @@ DateTimeVal TimestampFunctions::time_round(FunctionContext* ctx, const DateTimeV
return new_ts_val;
}
+DateTimeVal TimestampFunctions::last_day(FunctionContext* ctx, const DateTimeVal& ts_val) {
+ if (ts_val.is_null) {
+ return DateTimeVal::null();
+ }
+ const DateTimeValue& ts_value = DateTimeValue::from_datetime_val(ts_val);
+ int last_days[12] = {31,28,31,30,31,30,31,31,30,31,30,31};
Review comment:
this array can be a static member.
##########
File path: be/src/exprs/timestamp_functions.cpp
##########
@@ -608,6 +608,28 @@ DateTimeVal TimestampFunctions::time_round(FunctionContext* ctx, const DateTimeV
return new_ts_val;
}
+DateTimeVal TimestampFunctions::last_day(FunctionContext* ctx, const DateTimeVal& ts_val) {
+ if (ts_val.is_null) {
+ return DateTimeVal::null();
+ }
+ const DateTimeValue& ts_value = DateTimeValue::from_datetime_val(ts_val);
+ int last_days[12] = {31,28,31,30,31,30,31,31,30,31,30,31};
+ int day ;
+ int year = ts_value.year();
+ int month = ts_value.month();
+ if((year % 4 == 0 && year % 100 !=0)||(year % 400 ==0 )) {
+ day = 29 ;
+ } else {
+ day = last_days[month - 1];
Review comment:
ident
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org