You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/12 09:44:35 UTC

[GitHub] [pulsar] zymap commented on a change in pull request #8535: [pulsar-perf] Support WebSocket Producer for V2 Topics

zymap commented on a change in pull request #8535:
URL: https://github.com/apache/pulsar/pull/8535#discussion_r521970529



##########
File path: pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java
##########
@@ -166,7 +168,9 @@ public void runPerformanceTest(long messages, long limit, int numOfTopic, int si
             String topicName, String authPluginClassName, String authParams) throws InterruptedException, FileNotFoundException {
         ExecutorService executor = Executors.newCachedThreadPool(new DefaultThreadFactory("pulsar-perf-producer-exec"));
         HashMap<String, Tuple> producersMap = new HashMap<>();
-        String produceBaseEndPoint = baseUrl + "ws/producer" + topicName;
+        String replacedTopicName = topicName.replace("://", "/");

Review comment:
       I think there has a method `getRestPath` in the TopicName do the same thing with you.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org